* [PATCH] python-pygtk: Restore pkg-config file
@ 2014-10-28 15:05 Gary Thomas
2014-10-30 12:57 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Gary Thomas @ 2014-10-28 15:05 UTC (permalink / raw)
To: openembedded-core; +Cc: Gary Thomas
Some previous version of this recipe was errantly removing the pygtk-2.0.pc
(pkg-config) file. This is needed for other packages to be able to build
against this library.
Also update the .pc file to match current pkg-config use (libdir was missing).
Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
.../python/python-pygtk/fix-pygtk-2.0.pc.patch | 13 +++++++++++++
meta/recipes-devtools/python/python-pygtk_2.24.0.bb | 2 +-
2 files changed, 14 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-devtools/python/python-pygtk/fix-pygtk-2.0.pc.patch
diff --git a/meta/recipes-devtools/python/python-pygtk/fix-pygtk-2.0.pc.patch b/meta/recipes-devtools/python/python-pygtk/fix-pygtk-2.0.pc.patch
new file mode 100644
index 0000000..b615654
--- /dev/null
+++ b/meta/recipes-devtools/python/python-pygtk/fix-pygtk-2.0.pc.patch
@@ -0,0 +1,13 @@
+Upstream-Status: Inappropriate [configuration]
+
+Index: pygtk-2.24.0/pygtk-2.0.pc.in
+===================================================================
+--- pygtk-2.24.0.orig/pygtk-2.0.pc.in
++++ pygtk-2.24.0/pygtk-2.0.pc.in
+@@ -1,5 +1,6 @@
+ prefix=@prefix@
+ exec_prefix=@exec_prefix@
++libdir=@libdir@
+ includedir=@includedir@
+ datarootdir=@datarootdir@
+ datadir=@datadir@
diff --git a/meta/recipes-devtools/python/python-pygtk_2.24.0.bb b/meta/recipes-devtools/python/python-pygtk_2.24.0.bb
index 8fc194f..bd26ebb 100644
--- a/meta/recipes-devtools/python/python-pygtk_2.24.0.bb
+++ b/meta/recipes-devtools/python/python-pygtk_2.24.0.bb
@@ -15,6 +15,7 @@ SRC_URI = "ftp://ftp.gnome.org/pub/gnome/sources/pygtk/2.24/${SRCNAME}-${PV}.tar
file://fix-gtkunixprint.patch \
file://prevent_to_get_display_during_import.patch \
file://nodocs.patch \
+ file://fix-pygtk-2.0.pc.patch \
file://acinclude.m4 \
file://update-dependences-of-defs.c.patch"
@@ -43,7 +44,6 @@ do_configure_prepend() {
do_install_append() {
find ${D} -name "*.la"|xargs rm -f
rm -f ${D}/${bindir}/pygtk-codegen-2.0
- rm -rf ${D}/${libdir}/pkgconfig
sed -i -e '1s|^#!.*python|#!/usr/bin/env python|' ${D}${bindir}/pygtk-demo
}
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] python-pygtk: Restore pkg-config file
2014-10-28 15:05 [PATCH] python-pygtk: Restore pkg-config file Gary Thomas
@ 2014-10-30 12:57 ` Burton, Ross
2014-10-30 15:26 ` Andreas Müller
0 siblings, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2014-10-30 12:57 UTC (permalink / raw)
To: Gary Thomas; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
On 28 October 2014 15:05, Gary Thomas <gary@mlbassoc.com> wrote:
> Some previous version of this recipe was errantly removing the pygtk-2.0.pc
> (pkg-config) file. This is needed for other packages to be able to build
> against this library.
>
It's deleting the code generator too. This entire recipe gives me the
heebie-jeebies...
Ross
[-- Attachment #2: Type: text/html, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] python-pygtk: Restore pkg-config file
2014-10-30 12:57 ` Burton, Ross
@ 2014-10-30 15:26 ` Andreas Müller
2014-10-30 15:39 ` Gary Thomas
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Müller @ 2014-10-30 15:26 UTC (permalink / raw)
To: Burton, Ross; +Cc: Gary Thomas, OE-core
On Thu, Oct 30, 2014 at 1:57 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 28 October 2014 15:05, Gary Thomas <gary@mlbassoc.com> wrote:
>>
>> Some previous version of this recipe was errantly removing the
>> pygtk-2.0.pc
>> (pkg-config) file. This is needed for other packages to be able to build
>> against this library.
>
>
> It's deleting the code generator too. This entire recipe gives me the
> heebie-jeebies...
>
> Ross
>
I have a similar patch in for very long time [1]. At the time of
creation I ran several tests without suspicious results. The whole
'dirty fix #1' can go.
Andreas
[1] https://gitorious.org/schnitzeltony-oe-meta/oe-core/commit/dedf83428f297e9461f5c88c32c78192fa96585e
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] python-pygtk: Restore pkg-config file
2014-10-30 15:26 ` Andreas Müller
@ 2014-10-30 15:39 ` Gary Thomas
2014-10-30 16:14 ` Andreas Müller
0 siblings, 1 reply; 6+ messages in thread
From: Gary Thomas @ 2014-10-30 15:39 UTC (permalink / raw)
To: Andreas Müller, Burton, Ross; +Cc: OE-core
On 2014-10-30 09:26, Andreas Müller wrote:
> On Thu, Oct 30, 2014 at 1:57 PM, Burton, Ross <ross.burton@intel.com> wrote:
>>
>> On 28 October 2014 15:05, Gary Thomas <gary@mlbassoc.com> wrote:
>>>
>>> Some previous version of this recipe was errantly removing the
>>> pygtk-2.0.pc
>>> (pkg-config) file. This is needed for other packages to be able to build
>>> against this library.
>>
>>
>> It's deleting the code generator too. This entire recipe gives me the
>> heebie-jeebies...
>>
>> Ross
>>
> I have a similar patch in for very long time [1]. At the time of
> creation I ran several tests without suspicious results. The whole
> 'dirty fix #1' can go.
>
> Andreas
>
> [1] https://gitorious.org/schnitzeltony-oe-meta/oe-core/commit/dedf83428f297e9461f5c88c32c78192fa96585e
>
Wow, since Jan 2013 and no action?
Was this proposed to OE-core (i.e. sent to the list)?
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] python-pygtk: Restore pkg-config file
2014-10-30 15:39 ` Gary Thomas
@ 2014-10-30 16:14 ` Andreas Müller
2014-10-30 17:28 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Müller @ 2014-10-30 16:14 UTC (permalink / raw)
To: Gary Thomas; +Cc: OE-core
On Thu, Oct 30, 2014 at 4:39 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>
> Wow, since Jan 2013 and no action?
>
> Was this proposed to OE-core (i.e. sent to the list)?
>
No - my expiereineces sending patches to oe-core are not the best.
Usually they just cause me efforts and aren't applied anyway..
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] python-pygtk: Restore pkg-config file
2014-10-30 16:14 ` Andreas Müller
@ 2014-10-30 17:28 ` Richard Purdie
0 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2014-10-30 17:28 UTC (permalink / raw)
To: Andreas Müller; +Cc: Gary Thomas, OE-core
On Thu, 2014-10-30 at 17:14 +0100, Andreas Müller wrote:
> On Thu, Oct 30, 2014 at 4:39 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> >
> > Wow, since Jan 2013 and no action?
> >
> > Was this proposed to OE-core (i.e. sent to the list)?
> >
> No - my expiereineces sending patches to oe-core are not the best.
> Usually they just cause me efforts and aren't applied anyway..
Its sad that you feel that and if we can, I'd like to try and fix that
somehow.
People do try their best, equally, the response against the maintainers
if something goes wrong hasn't been ideal either.
Is there anything specific we can try and do better?
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-30 17:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-28 15:05 [PATCH] python-pygtk: Restore pkg-config file Gary Thomas
2014-10-30 12:57 ` Burton, Ross
2014-10-30 15:26 ` Andreas Müller
2014-10-30 15:39 ` Gary Thomas
2014-10-30 16:14 ` Andreas Müller
2014-10-30 17:28 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox