[PATCH] base: Make PRINC warning an error

[PATCH] base: Make PRINC warning an error

[Richard Purdie]

Apparently 1.5 years of warnings isn't enough to get anyone to take any
notice. We therefore make this an error so people can ignore it for
another 6 months whereafter we can finally give up and remove the
obsolete code.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index e1b25ff..f5b216b 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -375,7 +375,7 @@ python () {
     # obsolete.  Return a warning to the user.
     princ = d.getVar('PRINC', True)
     if princ and princ != "0":
-        bb.warn("Use of PRINC %s was detected in the recipe %s (or one of its .bbappends)\nUse of PRINC is deprecated.  The PR server should be used to automatically increment the PR.  See: https://wiki.yoctoproject.org/wiki/PR_Service." % (princ, d.getVar("FILE", True)))
+        bb.error("Use of PRINC %s was detected in the recipe %s (or one of its .bbappends)\nUse of PRINC is deprecated.  The PR server should be used to automatically increment the PR.  See: https://wiki.yoctoproject.org/wiki/PR_Service." % (princ, d.getVar("FILE", True)))
         pr = d.getVar('PR', True)
         pr_prefix = re.search("\D+",pr)
         prval = re.search("\d+",pr)

Re: [PATCH] base: Make PRINC warning an error

[Mark Hatle]

On 11/5/14, 12:43 PM, Richard Purdie wrote:
> Apparently 1.5 years of warnings isn't enough to get anyone to take any
> notice. We therefore make this an error so people can ignore it for
> another 6 months whereafter we can finally give up and remove the
> obsolete code.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index e1b25ff..f5b216b 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -375,7 +375,7 @@ python () {
>       # obsolete.  Return a warning to the user.
>       princ = d.getVar('PRINC', True)
>       if princ and princ != "0":
> -        bb.warn("Use of PRINC %s was detected in the recipe %s (or one of its .bbappends)\nUse of PRINC is deprecated.  The PR server should be used to automatically increment the PR.  See: https://wiki.yoctoproject.org/wiki/PR_Service." % (princ, d.getVar("FILE", True)))
> +        bb.error("Use of PRINC %s was detected in the recipe %s (or one of its .bbappends)\nUse of PRINC is deprecated.  The PR server should be used to automatically increment the PR.  See: https://wiki.yoctoproject.org/wiki/PR_Service." % (princ, d.getVar("FILE", True)))
>           pr = d.getVar('PR', True)
>           pr_prefix = re.search("\D+",pr)
>           prval = re.search("\d+",pr)
>
>

I'd suggest removing the code -after- the bb.error as well..

Make it an error.. and remove the functionality so it's -clear- you can't just 
make it a warning again.

--Mark