[PATCH] dtc: don't use autotools as this doesn't use autotools

[PATCH] dtc: don't use autotools as this doesn't use autotools

[Ross Burton]

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-kernel/dtc/dtc.inc |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-kernel/dtc/dtc.inc b/meta/recipes-kernel/dtc/dtc.inc
index 95023b6..0c409b0 100644
--- a/meta/recipes-kernel/dtc/dtc.inc
+++ b/meta/recipes-kernel/dtc/dtc.inc
@@ -4,16 +4,18 @@ SECTION = "bootloader"
 LICENSE = "GPLv2 | BSD"
 DEPENDS = "flex-native bison-native"
 
-inherit autotools-brokensep
-
 SRC_URI = "git://git.kernel.org/pub/scm/utils/dtc/dtc.git \
            file://make_install.patch \
 	  "
 
-EXTRA_OEMAKE='PREFIX="${prefix}" LIBDIR="${libdir}"'
+EXTRA_OEMAKE='PREFIX="${prefix}" LIBDIR="${libdir}" DESTDIR="${D}"'
 
 S = "${WORKDIR}/git"
 
+do_install () {
+	oe_runmake install
+}
+
 PACKAGES =+ "${PN}-misc"
 FILES_${PN}-misc = "${bindir}/convert-dtsv0 ${bindir}/ftdump ${bindir}/dtdiff"
 
-- 
1.7.10.4

Re: [PATCH] dtc: don't use autotools as this doesn't use autotools

[Koen Kooi]

> Op 5 dec. 2014, om 21:46 heeft Ross Burton <ross.burton@intel.com> het volgende geschreven:
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-kernel/dtc/dtc.inc |    8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-kernel/dtc/dtc.inc b/meta/recipes-kernel/dtc/dtc.inc
> index 95023b6..0c409b0 100644
> --- a/meta/recipes-kernel/dtc/dtc.inc
> +++ b/meta/recipes-kernel/dtc/dtc.inc

[..]

> +do_install () {
> +	oe_runmake install
> +}

I'm wondering if it makes sense to have base.bbclass do this the default do_install. Having a virtually empty recipe with only a do_install always makes me a bit uneasy.

regards,

Koen

Re: [PATCH] dtc: don't use autotools as this doesn't use autotools

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

On Sat, Dec 6, 2014 at 4:00 AM, Koen Kooi <koen@dominion.thruhere.net>
wrote:

> > Op 5 dec. 2014, om 21:46 heeft Ross Burton <ross.burton@intel.com> het
> volgende geschreven:
> >
> > Signed-off-by: Ross Burton <ross.burton@intel.com>
> > ---
> > meta/recipes-kernel/dtc/dtc.inc |    8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/recipes-kernel/dtc/dtc.inc
> b/meta/recipes-kernel/dtc/dtc.inc
> > index 95023b6..0c409b0 100644
> > --- a/meta/recipes-kernel/dtc/dtc.inc
> > +++ b/meta/recipes-kernel/dtc/dtc.inc
>
> [..]
>
> > +do_install () {
> > +     oe_runmake install
> > +}
>
> I'm wondering if it makes sense to have base.bbclass do this the default
> do_install. Having a virtually empty recipe with only a do_install always
> makes me a bit uneasy.
>

The problem with that is DESTDIR is an automake convention.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1669 bytes --]

Re: [PATCH] dtc: don't use autotools as this doesn't use autotools

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

On 7 December 2014 at 01:38, Christopher Larson <clarson@kergoth.com> wrote:

> The problem with that is DESTDIR is an automake convention.
>

Yes, outside of automake there's just too much variety to make providing
defaults useful.

Ross

[-- Attachment #2: Type: text/html, Size: 613 bytes --]

Re: [PATCH] dtc: don't use autotools as this doesn't use autotools

[Enrico Scholz]

Christopher Larson <clarson-ZYzTKstmaoRBDgjK7y7TUQ@public.gmane.org>
writes:

> The problem with that is DESTDIR is an automake convention.

Not only automake, it is part of the "GNU coding standards" (--> info
standards).


Enrico