From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/4] busybox.inc: fix QA package-missing warnings
Date: Sat, 27 Dec 2014 14:28:56 +0000 [thread overview]
Message-ID: <1419690536.29930.0.camel@linuxfoundation.org> (raw)
In-Reply-To: <549EBB98.2090006@topic.nl>
On Sat, 2014-12-27 at 15:00 +0100, Mike Looijmans wrote:
> On 12/26/2014 02:59 PM, Otavio Salvador wrote:
> > On Wed, Dec 24, 2014 at 11:48 PM, Hongxu Jia <hongxu.jia@windriver.com> wrote:
> >> While building busybox with QA package-missing checking enabled,
> >> there was warning:
> >> ...
> >> WARNING: QA Issue: package busybox-mdev not generated, but listed in PACKAGES
> >> WARNING: QA Issue: package busybox-httpd not generated, but listed in PACKAGES
> >> ...
> >>
> >> The config in ${B}/.config decides to generate busybox-mdev,
> >> busybox-httpd or not. Files are copied if the packages generated.
> >> So set PACKAGES in do_package according to the existance of files.
> >>
> >> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> >
> > Shouldn't we "invert" the logic here? This patch 'removes' httpd and
> > mdev when those are not enabled. Why we don't /add/ those when they
> > are enabled?
>
> maybe the answer is in a question:
> What would happen then if someone typed "bitbake busybox-mdev"?
You'd get an error regardless since "busybox-mdev" isn't a recipe, its a
package and bitbake doesn't take package names.
Cheers,
Richard
next prev parent reply other threads:[~2014-12-27 14:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 1:48 [PATCH V2 0/4] insane.bbclass: add QA check: package-missing Hongxu Jia
2014-12-25 1:48 ` [PATCH 1/4] " Hongxu Jia
2014-12-25 1:48 ` [PATCH 2/4] perl_5.20.0: fix QA package-missing warnings Hongxu Jia
2014-12-25 1:48 ` [PATCH 3/4] linux-libc-headers.inc: " Hongxu Jia
2014-12-26 13:58 ` Otavio Salvador
2014-12-29 8:16 ` [PATCH V2 " Hongxu Jia
2014-12-25 1:48 ` [PATCH 4/4] busybox.inc: " Hongxu Jia
2014-12-26 13:59 ` Otavio Salvador
2014-12-27 14:00 ` Mike Looijmans
2014-12-27 14:28 ` Richard Purdie [this message]
2014-12-29 8:16 ` [PATCH V2 " Hongxu Jia
2014-12-29 8:19 ` Hongxu Jia
2014-12-29 10:45 ` [PATCH V3 " Hongxu Jia
2014-12-29 10:50 ` Hongxu Jia
2015-01-09 11:50 ` [PATCH V2 0/4] insane.bbclass: add QA check: package-missing Hongxu Jia
-- strict thread matches above, loose matches on Subject: below --
2014-12-11 10:27 [PATCH " Hongxu Jia
2014-12-11 10:27 ` [PATCH 4/4] busybox.inc: fix QA package-missing warnings Hongxu Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419690536.29930.0.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=mike.looijmans@topic.nl \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox