From: Mike Looijmans <mike.looijmans@topic.nl>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/4] busybox.inc: fix QA package-missing warnings
Date: Sat, 27 Dec 2014 15:00:56 +0100 [thread overview]
Message-ID: <549EBB98.2090006@topic.nl> (raw)
In-Reply-To: <CAP9ODKqYTffL5+7uY9VTbR9nM1bMU9nA5rb0-C0FXm3GmX3POQ@mail.gmail.com>
On 12/26/2014 02:59 PM, Otavio Salvador wrote:
> On Wed, Dec 24, 2014 at 11:48 PM, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> While building busybox with QA package-missing checking enabled,
>> there was warning:
>> ...
>> WARNING: QA Issue: package busybox-mdev not generated, but listed in PACKAGES
>> WARNING: QA Issue: package busybox-httpd not generated, but listed in PACKAGES
>> ...
>>
>> The config in ${B}/.config decides to generate busybox-mdev,
>> busybox-httpd or not. Files are copied if the packages generated.
>> So set PACKAGES in do_package according to the existance of files.
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>
> Shouldn't we "invert" the logic here? This patch 'removes' httpd and
> mdev when those are not enabled. Why we don't /add/ those when they
> are enabled?
maybe the answer is in a question:
What would happen then if someone typed "bitbake busybox-mdev"?
--
Mike Looijmans
next prev parent reply other threads:[~2014-12-27 14:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 1:48 [PATCH V2 0/4] insane.bbclass: add QA check: package-missing Hongxu Jia
2014-12-25 1:48 ` [PATCH 1/4] " Hongxu Jia
2014-12-25 1:48 ` [PATCH 2/4] perl_5.20.0: fix QA package-missing warnings Hongxu Jia
2014-12-25 1:48 ` [PATCH 3/4] linux-libc-headers.inc: " Hongxu Jia
2014-12-26 13:58 ` Otavio Salvador
2014-12-29 8:16 ` [PATCH V2 " Hongxu Jia
2014-12-25 1:48 ` [PATCH 4/4] busybox.inc: " Hongxu Jia
2014-12-26 13:59 ` Otavio Salvador
2014-12-27 14:00 ` Mike Looijmans [this message]
2014-12-27 14:28 ` Richard Purdie
2014-12-29 8:16 ` [PATCH V2 " Hongxu Jia
2014-12-29 8:19 ` Hongxu Jia
2014-12-29 10:45 ` [PATCH V3 " Hongxu Jia
2014-12-29 10:50 ` Hongxu Jia
2015-01-09 11:50 ` [PATCH V2 0/4] insane.bbclass: add QA check: package-missing Hongxu Jia
-- strict thread matches above, loose matches on Subject: below --
2014-12-11 10:27 [PATCH " Hongxu Jia
2014-12-11 10:27 ` [PATCH 4/4] busybox.inc: fix QA package-missing warnings Hongxu Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549EBB98.2090006@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox