[PATCH] xserver-xf86-config: Loading glx module

[PATCH] xserver-xf86-config: Loading glx module

[Sujith H]

From: Sujith H <Sujith_Haridasan@mentor.com>

This module was required to get opengl working with
Qt5 version 5.4 ( when tested with qemuarm and qemux86).
After adding this change to the xorg.conf and restarting
xserver qtquick and qtdeclarative examples of Qt5 started
working appropriately.

Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
Signed-off-by: Sujith H <sujith.h@gmail.com>
---
 meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb b/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb
index 549c7c8..391ebae 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb
@@ -17,4 +17,9 @@ do_install () {
 		install -d ${D}/${sysconfdir}/X11
 		install -m 0644 ${WORKDIR}/xorg.conf ${D}/${sysconfdir}/X11/
 	fi
+        cat >> ${D}/${sysconfdir}/X11/xorg.conf << EOF
+Section "Module"
+    Load           "glx"
+EndSection
+EOF
 }
-- 
1.8.4

[PATCH] xserver-xf86-config: Loading glx module

[Sujith H]

From: Sujith H <Sujith_Haridasan@mentor.com>

This module was required to get opengl working with
Qt5 version 5.4 ( when tested with qemuarm and qemux86).
After adding this change to the xorg.conf and restarting
xserver qtquick and qtdeclarative examples of Qt5 started
working appropriately.

Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
Signed-off-by: Sujith H <sujith.h@gmail.com>
---
 meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb b/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb
index 549c7c8..bcd9d8a 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb
@@ -17,4 +17,11 @@ do_install () {
 		install -d ${D}/${sysconfdir}/X11
 		install -m 0644 ${WORKDIR}/xorg.conf ${D}/${sysconfdir}/X11/
 	fi
+        if ${@bb.utils.contains('DISTRO_FEATURES','x11','true','false',d)}; then
+                cat >> ${D}/${sysconfdir}/X11/xorg.conf << EOF
+Section "Module"
+    Load           "glx"
+EndSection
+EOF
+        fi
 }
-- 
1.8.4

Re: [PATCH] xserver-xf86-config: Loading glx module

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On 6 January 2015 at 10:54, Sujith H <sujith.h@gmail.com> wrote:

> +        if
> ${@bb.utils.contains('DISTRO_FEATURES','x11','true','false',d)}; then
>

Why would a X11-specific recipe need an X11 feature check?


> +                cat >> ${D}/${sysconfdir}/X11/xorg.conf << EOF
> +Section "Module"
> +    Load           "glx"
> +EndSection
>

But GLX is automatically loaded by the xserver,  My test machine doesn't
have a xorg.conf and GLX loads on startup.  Does your machine configuration
ship a xorg.conf?

Ross

[-- Attachment #2: Type: text/html, Size: 1142 bytes --]

Re: [PATCH] xserver-xf86-config: Loading glx module

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

On Tue, Jan 6, 2015 at 5:00 PM, Burton, Ross <ross.burton@intel.com> wrote:

>
> On 6 January 2015 at 10:54, Sujith H <sujith.h@gmail.com> wrote:
>
>> +        if
>> ${@bb.utils.contains('DISTRO_FEATURES','x11','true','false',d)}; then
>>
>
> Why would a X11-specific recipe need an X11 feature check?
>
Correct, I will remove the x11 feature check from the patch.

>
>
>> +                cat >> ${D}/${sysconfdir}/X11/xorg.conf << EOF
>> +Section "Module"
>> +    Load           "glx"
>> +EndSection
>>
>
> But GLX is automatically loaded by the xserver,  My test machine doesn't
> have a xorg.conf and GLX loads on startup.  Does your machine configuration
> ship a xorg.conf?
>
No, we get the xorg.conf from this same recipe. And while I was testing
some opengl related examples from Qt5, I was getting error
saying: "could not initialize glx" . Hence I made a change in the recipe
and added IMAGE_INSTALL_append = " xserver-xorg-extension-glx" and it
worked fine. Hence I thought of adding this change. Let me know if there is
any issues/concern.

>
> Ross
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info

[-- Attachment #2: Type: text/html, Size: 2959 bytes --]

Re: [PATCH] xserver-xf86-config: Loading glx module

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

On 6 January 2015 at 12:51, sujith h <sujith.h@gmail.com> wrote:

> saying: "could not initialize glx" . Hence I made a change in the recipe
> and added IMAGE_INSTALL_append = " xserver-xorg-extension-glx" and it
> worked fine. Hence I thought of adding this change. Let me know if there is
> any issues/concern.
>
>>
Actually installing the GLX module in the image is a prerequisite to
loading the module...  you don't need to modify the xorg.conf - as I said
the GLX module (along with several other modules) are loaded automatically
*if present*.

Ross

[-- Attachment #2: Type: text/html, Size: 1210 bytes --]

Re: [PATCH] xserver-xf86-config: Loading glx module

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Tue, Jan 6, 2015 at 6:38 PM, Burton, Ross <ross.burton@intel.com> wrote:

>
> On 6 January 2015 at 12:51, sujith h <sujith.h@gmail.com> wrote:
>
>> saying: "could not initialize glx" . Hence I made a change in the recipe
>> and added IMAGE_INSTALL_append = " xserver-xorg-extension-glx" and it
>> worked fine. Hence I thought of adding this change. Let me know if there is
>> any issues/concern.
>>
>>>
> Actually installing the GLX module in the image is a prerequisite to
> loading the module...  you don't need to modify the xorg.conf - as I said
> the GLX module (along with several other modules) are loaded automatically
> *if present*.
>

Thanks for the clarification. I will check once again by adding glx module
to the image and remove the patch and see the result. I will update here.

>
> Ross
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info

[-- Attachment #2: Type: text/html, Size: 2361 bytes --]

Re: [PATCH] xserver-xf86-config: Loading glx module

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]

On Tue, Jan 6, 2015 at 6:41 PM, sujith h <sujith.h@gmail.com> wrote:

>
>
> On Tue, Jan 6, 2015 at 6:38 PM, Burton, Ross <ross.burton@intel.com>
> wrote:
>
>>
>> On 6 January 2015 at 12:51, sujith h <sujith.h@gmail.com> wrote:
>>
>>> saying: "could not initialize glx" . Hence I made a change in the recipe
>>> and added IMAGE_INSTALL_append = " xserver-xorg-extension-glx" and it
>>> worked fine. Hence I thought of adding this change. Let me know if there is
>>> any issues/concern.
>>>
>>>>
>> Actually installing the GLX module in the image is a prerequisite to
>> loading the module...  you don't need to modify the xorg.conf - as I said
>> the GLX module (along with several other modules) are loaded automatically
>> *if present*.
>>
>
> Thanks for the clarification. I will check once again by adding glx module
> to the image and remove the patch and see the result. I will update here.
>

Just now I had verified and thanks for the clarification again. It worked
by removing the patch I had created and adding  xserver-xorg-extension-glx
to the image. Good learning for me :)


>> Ross
>>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info

[-- Attachment #2: Type: text/html, Size: 3651 bytes --]

[PATCH] xserver-xf86-config: Loading glx module

[Sujith H]

From: Sujith H <Sujith_Haridasan@mentor.com>

This module was required to get opengl working with
Qt5 version 5.4 ( when tested with qemuarm and qemux86).
After adding this change to the xorg.conf and restarting
xserver qtquick and qtdeclarative examples of Qt5 started
working appropriately.

Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
Signed-off-by: Sujith H <sujith.h@gmail.com>
---
 meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb b/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb
index 549c7c8..bcd9d8a 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bb
@@ -17,4 +17,11 @@ do_install () {
 		install -d ${D}/${sysconfdir}/X11
 		install -m 0644 ${WORKDIR}/xorg.conf ${D}/${sysconfdir}/X11/
 	fi
+        if ${@bb.utils.contains('DISTRO_FEATURES','x11','true','false',d)}; then
+                cat >> ${D}/${sysconfdir}/X11/xorg.conf << EOF
+Section "Module"
+    Load           "glx"
+EndSection
+EOF
+        fi
 }
-- 
1.8.4