[PATCH] kernel.bbclass: change oldnoconfig to olddefconfig

[PATCH] kernel.bbclass: change oldnoconfig to olddefconfig

[Bob Cochran]

KERNEL_CONFIG_COMMAND is defined as passing oldnoconfig to
oe_runmake_call, but oldnoconfig is both an alias to olddefconfig and a
misleading name.  Therefore, change it to the meaningfully named
option: olddefconfig.

For further background, please see commit fb16d8912db5268f29706010ecafff74b971c58d  in
Linux kernel source tree:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fb16d8912db5268f29706010ecafff74b971c58d

Signed-off-by: Bob Cochran <openembedded@mindchasers.com>
---
 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 88356b1..aebbc65 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -275,7 +275,7 @@ python sysroot_stage_all () {
     oe.path.copyhardlinktree(d.expand("${D}${KERNEL_SRC_PATH}"), d.expand("${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}"))
 }
 
-KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} O=${B} oldnoconfig || yes '' | oe_runmake -C ${S} O=${B} oldconfig"
+KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} O=${B} olddefconfig || yes '' | oe_runmake -C ${S} O=${B} oldconfig"
 
 kernel_do_configure() {
 	# fixes extra + in /lib/modules/2.6.37+
-- 
1.7.9.5

Re: [PATCH] kernel.bbclass: change oldnoconfig to olddefconfig

[Bruce Ashfield]

On Fri, Jan 9, 2015 at 1:04 PM, Bob Cochran
<openembedded@mindchasers.com> wrote:
> KERNEL_CONFIG_COMMAND is defined as passing oldnoconfig to
> oe_runmake_call, but oldnoconfig is both an alias to olddefconfig and a
> misleading name.  Therefore, change it to the meaningfully named
> option: olddefconfig.

We've discussed this on the mailing list before. To keep compatibility with
the widest range of possible kernels, we are using the oldest target
on purpose, with
a fallback where appropriate:

http://lists.openembedded.org/pipermail/openembedded-core/2014-February/089242.html
https://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg49040.html

Cheers,

Bruce

>
> For further background, please see commit fb16d8912db5268f29706010ecafff74b971c58d  in
> Linux kernel source tree:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fb16d8912db5268f29706010ecafff74b971c58d
>
> Signed-off-by: Bob Cochran <openembedded@mindchasers.com>
> ---
>  meta/classes/kernel.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 88356b1..aebbc65 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -275,7 +275,7 @@ python sysroot_stage_all () {
>      oe.path.copyhardlinktree(d.expand("${D}${KERNEL_SRC_PATH}"), d.expand("${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}"))
>  }
>
> -KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} O=${B} oldnoconfig || yes '' | oe_runmake -C ${S} O=${B} oldconfig"
> +KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} O=${B} olddefconfig || yes '' | oe_runmake -C ${S} O=${B} oldconfig"
>
>  kernel_do_configure() {
>         # fixes extra + in /lib/modules/2.6.37+
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"