Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] dpkg: add triplet entry to fix build error for armeb
@ 2015-04-08 13:33 Krishnanjanappa, Jagadeesh
  2015-04-08 13:43 ` Anders Darander
  0 siblings, 1 reply; 4+ messages in thread
From: Krishnanjanappa, Jagadeesh @ 2015-04-08 13:33 UTC (permalink / raw)
  To: openembedded-core

From: "Krishnanjanappa, Jagadeesh" <jagadeesh.krishnanjanappa@caviumnetworks.com>

1. Cross-compling dpkg application for armeb fails with below error
   during configure task,

    (snip)
    configure:23141: checking dpkg cpu type
    configure:23148: result: armeb
    configure:23150: WARNING: armeb not found in cputable
    configure:23162: checking dpkg operating system type
    configure:23169: result: linux-gnueabi
    configure:23171: WARNING: linux-gnueabi not found in ostable
    configure:23183: checking dpkg architecture name
    configure:23189: error: cannot determine host dpkg architecture
    -- CUT --

    Add the required combination of "gnueabi-linux-armeb" entry in
    triplet list.

2. Added INC_PR to PR to have an updated value, when INC_PR is defined
   in dpkg.inc file

Signed-off-by: Krishnanjanappa, Jagadeesh <jagadeesh.krishnanjanappa@caviumnetworks.com>
---
 .../dpkg/dpkg/add_armeb_triplet_entry.patch        | 38 ++++++++++++++++++++++
 meta/recipes-devtools/dpkg/dpkg_1.17.21.bb         |  4 +++
 2 files changed, 42 insertions(+)
 create mode 100644 meta/recipes-devtools/dpkg/dpkg/add_armeb_triplet_entry.patch

diff --git a/meta/recipes-devtools/dpkg/dpkg/add_armeb_triplet_entry.patch b/meta/recipes-devtools/dpkg/dpkg/add_armeb_triplet_entry.patch
new file mode 100644
index 0000000..af275de
--- /dev/null
+++ b/meta/recipes-devtools/dpkg/dpkg/add_armeb_triplet_entry.patch
@@ -0,0 +1,38 @@
+Author: Krishnanjanappa, Jagadeesh <jagadeesh.krishnanjanappa@caviumnetworks.com>
+Date:   Wed Apr 8 18:08:14 2015 +0530
+
+[PATCH] add armeb triplet entry into triplettable.
+
+Cross-compling dpkg application for armeb fails with below error
+during configure task,
+
+(snip)
+ configure:23141: checking dpkg cpu type
+ configure:23148: result: armeb
+ configure:23150: WARNING: armeb not found in cputable
+ configure:23162: checking dpkg operating system type
+ configure:23169: result: linux-gnueabi
+ configure:23171: WARNING: linux-gnueabi not found in ostable
+ configure:23183: checking dpkg architecture name
+ configure:23189: error: cannot determine host dpkg architecture
+-- CUT --
+
+the required combination of "gnueabi-linux-armeb" was not found in
+the triplettable file thereby returning dpkg_arch as
+empty in configure script.
+
+Upstream-Status: Pending
+
+Signed-off-by: Krishnanjanappa, Jagadeesh <jagadeesh.krishnanjanappa@caviumnetworks.com>
+
+diff -Naurp dpkg-1.17.21_org/triplettable dpkg-1.17.21/triplettable
+--- dpkg-1.17.21_org/triplettable	2015-04-08 17:08:52.370759171 +0530
++++ dpkg-1.17.21/triplettable	2015-04-08 17:09:12.406752081 +0530
+@@ -9,6 +9,7 @@ musleabihf-linux-arm	musl-linux-armhf
+ musl-linux-<cpu>	musl-linux-<cpu>
+ gnueabihf-linux-arm	armhf
+ gnueabi-linux-arm	armel
++gnueabi-linux-armeb	armeb
+ gnuabin32-linux-mips64el	mipsn32el
+ gnuabin32-linux-mips64	mipsn32
+ gnuabi64-linux-mips64el	mips64el
diff --git a/meta/recipes-devtools/dpkg/dpkg_1.17.21.bb b/meta/recipes-devtools/dpkg/dpkg_1.17.21.bb
index 15c0277..06c690b 100644
--- a/meta/recipes-devtools/dpkg/dpkg_1.17.21.bb
+++ b/meta/recipes-devtools/dpkg/dpkg_1.17.21.bb
@@ -1,6 +1,9 @@
 require dpkg.inc
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 
+INC_PR ?= "r0"
+PR = "${INC_PR}.1"
+
 SRC_URI += "file://noman.patch \
             file://check_snprintf.patch \
             file://check_version.patch \
@@ -12,6 +15,7 @@ SRC_URI += "file://noman.patch \
             file://dpkg-configure.service \
             file://glibc2.5-sync_file_range.patch \
             file://no-vla-warning.patch \
+            file://add_armeb_triplet_entry.patch \
            "
 
 SRC_URI[md5sum] = "765a96fd0180196613bbfa3c4aef0775"
-- 
1.8.2.3



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dpkg: add triplet entry to fix build error for armeb
  2015-04-08 13:33 [PATCH] dpkg: add triplet entry to fix build error for armeb Krishnanjanappa, Jagadeesh
@ 2015-04-08 13:43 ` Anders Darander
  2015-04-08 14:43   ` Krishnanjanappa, Jagadeesh
  0 siblings, 1 reply; 4+ messages in thread
From: Anders Darander @ 2015-04-08 13:43 UTC (permalink / raw)
  To: Krishnanjanappa, Jagadeesh; +Cc: openembedded-core

* Krishnanjanappa, Jagadeesh <jagadeesh.krishnanjanappa@caviumnetworks.com> [150408 15:33]:

> 2. Added INC_PR to PR to have an updated value, when INC_PR is defined
>    in dpkg.inc file

Drop INC_PR from this patch.
There's no INC_PR in the .inc file, and besides that, we're not touching
PR at all, unless we're really forced to. 

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dpkg: add triplet entry to fix build error for armeb
  2015-04-08 13:43 ` Anders Darander
@ 2015-04-08 14:43   ` Krishnanjanappa, Jagadeesh
  2015-04-08 15:06     ` Otavio Salvador
  0 siblings, 1 reply; 4+ messages in thread
From: Krishnanjanappa, Jagadeesh @ 2015-04-08 14:43 UTC (permalink / raw)
  To: Anders Darander; +Cc: openembedded-core@lists.openembedded.org

>Drop INC_PR from this patch.
>There's no INC_PR in the .inc file, and besides that, we're not touching
>PR at all, unless we're really forced to.

Yes, there is no INC_PR defined in dpkg.inc file.
The intention was if anyone wants to update dpkg.inc file in future, they
can define INC_PR in dpkg.inc file and then the updated INC_PR value 
will be reflected in recipe file. I felt this would help to track changes in
dpkg application build.

However, I have sent Patch v2 with INC_PR, PR removed.

Thanks,
Jagadeesh
_____________________________________
From: Anders Darander <anders@chargestorm.se>
Sent: Wednesday, April 8, 2015 7:13 PM
To: Krishnanjanappa, Jagadeesh
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] dpkg: add triplet entry to fix build error for armeb

* Krishnanjanappa, Jagadeesh <jagadeesh.krishnanjanappa@caviumnetworks.com> [150408 15:33]:

> 2. Added INC_PR to PR to have an updated value, when INC_PR is defined
>    in dpkg.inc file

Drop INC_PR from this patch.
There's no INC_PR in the .inc file, and besides that, we're not touching
PR at all, unless we're really forced to.

Cheers,
Anders

--
Anders Darander
ChargeStorm AB / eStorm AB

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dpkg: add triplet entry to fix build error for armeb
  2015-04-08 14:43   ` Krishnanjanappa, Jagadeesh
@ 2015-04-08 15:06     ` Otavio Salvador
  0 siblings, 0 replies; 4+ messages in thread
From: Otavio Salvador @ 2015-04-08 15:06 UTC (permalink / raw)
  To: Krishnanjanappa, Jagadeesh
  Cc: Anders Darander, openembedded-core@lists.openembedded.org

Hello Jagadeesh,

On Wed, Apr 8, 2015 at 11:43 AM, Krishnanjanappa, Jagadeesh
<Jagadeesh.Krishnanjanappa@caviumnetworks.com> wrote:
>>Drop INC_PR from this patch.
>>There's no INC_PR in the .inc file, and besides that, we're not touching
>>PR at all, unless we're really forced to.
>
> Yes, there is no INC_PR defined in dpkg.inc file.
> The intention was if anyone wants to update dpkg.inc file in future, they
> can define INC_PR in dpkg.inc file and then the updated INC_PR value
> will be reflected in recipe file. I felt this would help to track changes in
> dpkg application build.

The reason why Anders asked for the removal is that we do not use
manual bumping of PR to track most changes in recipes (there are some
rare cases it is needed) but the PR Service[1] which works in a much
more reliable way for end user.

1. https://wiki.yoctoproject.org/wiki/PR_Service

> However, I have sent Patch v2 with INC_PR, PR removed.

Thanks for your prompt act on this.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-04-08 15:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-08 13:33 [PATCH] dpkg: add triplet entry to fix build error for armeb Krishnanjanappa, Jagadeesh
2015-04-08 13:43 ` Anders Darander
2015-04-08 14:43   ` Krishnanjanappa, Jagadeesh
2015-04-08 15:06     ` Otavio Salvador

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox