[PATCH] oe-init-build-env: fix for build dirs that have spaces in their path

[PATCH] oe-init-build-env: fix for build dirs that have spaces in their path

[Joshua Lock]

Enclose expansions of BUILDDIR in quotes in order to correctly handle paths
which include spaces.

Signed-off-by: Joshua Lock <joshua.lock@collabora.co.uk>
---
 oe-init-build-env         |  2 +-
 scripts/oe-setup-builddir | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/oe-init-build-env b/oe-init-build-env
index 5249513..6fee5f7 100755
--- a/oe-init-build-env
+++ b/oe-init-build-env
@@ -46,7 +46,7 @@ OEROOT=`readlink -f "$OEROOT"`
 export OEROOT
 . $OEROOT/scripts/oe-buildenv-internal && \
      $OEROOT/scripts/oe-setup-builddir && \
-     [ -n "$BUILDDIR" ] && cd $BUILDDIR
+     [ -n "$BUILDDIR" ] && cd "$BUILDDIR"
 unset OEROOT
 unset BBPATH
 unset THIS_SCRIPT
diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir
index f73aa34..add0b50 100755
--- a/scripts/oe-setup-builddir
+++ b/scripts/oe-setup-builddir
@@ -23,7 +23,7 @@ if [ -z "$BUILDDIR" ]; then
     exit 1
 fi
 
-mkdir -p $BUILDDIR/conf
+mkdir -p "$BUILDDIR/conf"
 
 if [ ! -d "$BUILDDIR" ]; then
     echo >&2 "Error: The builddir ($BUILDDIR) does not exist!"
@@ -38,13 +38,13 @@ fi
 cd "$BUILDDIR"
 
 if [ -f "$BUILDDIR/conf/templateconf.cfg" ]; then
-    TEMPLATECONF=$(cat $BUILDDIR/conf/templateconf.cfg)
+    TEMPLATECONF=$(cat "$BUILDDIR/conf/templateconf.cfg")
 fi
 
 . $OEROOT/.templateconf
 
 if [ ! -f "$BUILDDIR/conf/templateconf.cfg" ]; then
-    echo "$TEMPLATECONF" >$BUILDDIR/conf/templateconf.cfg
+    echo "$TEMPLATECONF" >"$BUILDDIR/conf/templateconf.cfg"
 fi
 
 # 
@@ -79,7 +79,7 @@ advantage of multiple cores for example. See the file for more information as
 common configuration options are commented.
 
 EOM
-    cp -f $OECORELOCALCONF $BUILDDIR/conf/local.conf
+    cp -f $OECORELOCALCONF "$BUILDDIR/conf/local.conf"
     SHOWYPDOC=yes
 fi
 
@@ -100,7 +100,7 @@ EOM
     # to replace it for compatibility.
     sed -e "s|##OEROOT##|$OEROOT|g" \
         -e "s|##COREBASE##|$OEROOT|g" \
-        $OECORELAYERCONF > $BUILDDIR/conf/bblayers.conf
+        $OECORELAYERCONF > "$BUILDDIR/conf/bblayers.conf"
     SHOWYPDOC=yes
 fi
 
-- 
2.1.0

Re: [PATCH] oe-init-build-env: fix for build dirs that have spaces in their path

[Richard Purdie]

On Mon, 2015-04-13 at 16:30 +0100, Joshua Lock wrote:
> Enclose expansions of BUILDDIR in quotes in order to correctly handle paths
> which include spaces.
> 
> Signed-off-by: Joshua Lock <joshua.lock@collabora.co.uk>

Autotools cannot handle things with spaces so whilst this will fix the
environment setup part, I think you'll see sanity check warnings in
short order?

I did once start fixing this until I found it meant fixing auto* at
which point I gave up.

Cheers,

Richard