Re: [PATCH] connman: Enable automake dependency tracking

[Jukka Rissanen <jukka.rissanen@linux.intel.com>]

Hi Ross,

On pe, 2015-05-01 at 15:03 +0100, Burton, Ross wrote:
> 
> On 1 May 2015 at 12:41, Jukka Rissanen
> <jukka.rissanen@linux.intel.com> wrote:
>         The automake option --disable-dependency-tracking does not
>         work nicely
>         with ConnMan 1.29 release.
>         The reason is ConnMan commits
>         ac332c5d01b0737c18cb58c8ccc67cf6b0427e1d
>         and ea6c21b0b20f6f25b25386285d81d859dc843820 that change how
>         and when
>         various .in files are generated. After those commits, the auto
>         generated files / directories are created during compilation.
>         Earlier
>         they were generated by configure script.
> 
> 
> Yesterday I fixed this the other way: by adding mkdir calls to connman
> so that instead of requiring dependency tracking to be on so that
> directories are generated, the build makes the directories as
> required.
> 
> 
> 970e0ae was where dependency tracking was disabled on the rationale
> that it's slower, has races, and theoretically won't give us an
> advantage as we don't generally rebuild the same source tree
> repeatedly.

Ok, that makes sense.

> 
> 
> I'll submit my fix to connman in a moment.

Thanks, the connman patch looks good to me.


Cheers,
Jukka