[PATCH] connman: Enable automake dependency tracking

[PATCH] connman: Enable automake dependency tracking

[Jukka Rissanen]

The automake option --disable-dependency-tracking does not work nicely
with ConnMan 1.29 release.
The reason is ConnMan commits ac332c5d01b0737c18cb58c8ccc67cf6b0427e1d
and ea6c21b0b20f6f25b25386285d81d859dc843820 that change how and when
various .in files are generated. After those commits, the auto
generated files / directories are created during compilation. Earlier
they were generated by configure script.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
---
Hi,

I tried ConnMan 1.29 with fido and dizzy releases and this change
is required there. I assume the same problem will be seen in master
also. Poky code adds automake --disable-dependency-tracking
option to configure so I made a quick change and enabled it back
in connman.inc file.

I sent 8 Apr similar patch (it is already in master, commit bf8aa743d972)
that is also required in fido and dizzy if ConnMan 1.29 is going
to be used there.

Cheers,
Jukka

meta/recipes-connectivity/connman/connman.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index d068ba8..ad1032f 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -29,6 +29,7 @@ EXTRA_OECONF += "\
     --enable-test \
     --disable-polkit \
     --enable-client \
+    --enable-dependency-tracking \
 "
 
 PACKAGECONFIG ??= "wispr \
-- 
2.1.0

Re: [PATCH] connman: Enable automake dependency tracking

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

On 1 May 2015 at 12:41, Jukka Rissanen <jukka.rissanen@linux.intel.com>
wrote:

> The automake option --disable-dependency-tracking does not work nicely
> with ConnMan 1.29 release.
> The reason is ConnMan commits ac332c5d01b0737c18cb58c8ccc67cf6b0427e1d
> and ea6c21b0b20f6f25b25386285d81d859dc843820 that change how and when
> various .in files are generated. After those commits, the auto
> generated files / directories are created during compilation. Earlier
> they were generated by configure script.
>

Yesterday I fixed this the other way: by adding mkdir calls to connman so
that instead of requiring dependency tracking to be on so that directories
are generated, the build makes the directories as required.

970e0ae was where dependency tracking was disabled on the rationale that
it's slower, has races, and theoretically won't give us an advantage as we
don't generally rebuild the same source tree repeatedly.

I'll submit my fix to connman in a moment.

Ross

[-- Attachment #2: Type: text/html, Size: 1518 bytes --]

Re: [PATCH] connman: Enable automake dependency tracking

[Jukka Rissanen]

Hi Ross,

On pe, 2015-05-01 at 15:03 +0100, Burton, Ross wrote:
> 
> On 1 May 2015 at 12:41, Jukka Rissanen
> <jukka.rissanen@linux.intel.com> wrote:
>         The automake option --disable-dependency-tracking does not
>         work nicely
>         with ConnMan 1.29 release.
>         The reason is ConnMan commits
>         ac332c5d01b0737c18cb58c8ccc67cf6b0427e1d
>         and ea6c21b0b20f6f25b25386285d81d859dc843820 that change how
>         and when
>         various .in files are generated. After those commits, the auto
>         generated files / directories are created during compilation.
>         Earlier
>         they were generated by configure script.
> 
> 
> Yesterday I fixed this the other way: by adding mkdir calls to connman
> so that instead of requiring dependency tracking to be on so that
> directories are generated, the build makes the directories as
> required.
> 
> 
> 970e0ae was where dependency tracking was disabled on the rationale
> that it's slower, has races, and theoretically won't give us an
> advantage as we don't generally rebuild the same source tree
> repeatedly.

Ok, that makes sense.

> 
> 
> I'll submit my fix to connman in a moment.

Thanks, the connman patch looks good to me.


Cheers,
Jukka