From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG
Date: Sat, 09 May 2015 23:00:10 +0100 [thread overview]
Message-ID: <1431208810.30971.2.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJ86T=W2chZiZXvey7oeuisVYTEHkukKMQ5jFioZaA9HFY+vFQ@mail.gmail.com>
On Fri, 2015-05-08 at 13:35 -0700, Andre McCurdy wrote:
> On Fri, May 8, 2015 at 12:12 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
> > On Fri, May 8, 2015 at 4:07 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> > ...
> >> Or perhaps even use the "GSTREAMER_DEBUG" variable in gstreamer 1.x recipes?
> >
> > I think the PACKAGECONFIG is a nice compromise as it allows for
> > granular control over what to enable or not. It is easy to enable it
> > for recipes in a local.conf using pn-<package>_append or similar.
>
> Over-riding GSTREAMER_DEBUG could be done on a per-package basis too,
> if there's really a need to enable debugging selectively.
>
> However, I guess when you want to enable gstreamer debugging, you
> typically want to do so through-out gstreamer and all plug-ins... and
> needing to control PACKAGECONFIG for each recipe makes it harder to do
> that.
>
> Whatever happens, the GSTREAMER_DEBUG, GSTREAMER_1_DEBUG and
> GSTREAMER_1_0_DEBUG duplication should probably be fixed.
>
> I don't have a strong preference though and I'm stuck partnered with
> an SoC vendor who only supports Gtreamer 0.10, so I'll be watching
> from the sidelines as everyone else debugs GStreamer 1.x in oe-core
> :-(
I took the patch since I do think PACKAGECONFIG is an improvement for
this. We could build upon it with something like:
GSTREAMER_CONFIG = ""
PACKAGECONFIG ??= "${GSTREAMER_CONFIG}"
then setting GSTREAMER_CONFIG = "debug" could do what you describe if
there really is the demand for it.
Cheers,
Richard
next prev parent reply other threads:[~2015-05-09 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 15:04 [PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG Ricardo Ribalda Delgado
2015-05-08 15:04 ` [PATCH 2/2] gstreamer1.0: Make check selectable via PACKAGECONFIG Ricardo Ribalda Delgado
2015-05-08 19:07 ` [PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG Andre McCurdy
2015-05-08 19:12 ` Otavio Salvador
2015-05-08 20:35 ` Andre McCurdy
2015-05-09 22:00 ` Richard Purdie [this message]
2015-05-11 6:54 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431208810.30971.2.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox