[PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG

[PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG

[Ricardo Ribalda Delgado]

It is more elegant

Suggested-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0.inc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
index a01c33ce5ff9..17a0d7f839c4 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
@@ -9,11 +9,12 @@ DEPENDS = "glib-2.0 libxml2 bison-native flex-native"
 
 inherit autotools pkgconfig gettext
 
-GSTREAMER_1_DEBUG ?= "--disable-debug"
+PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"
+
 EXTRA_OECONF = "--disable-docbook --disable-gtk-doc \
                 --disable-dependency-tracking --disable-check \
                 --disable-examples --disable-tests \
-                --disable-valgrind ${GSTREAMER_1_DEBUG} \
+                --disable-valgrind \
                 "
 
 RRECOMMENDS_${PN}_qemux86    += "kernel-module-snd-ens1370 kernel-module-snd-rawmidi"
-- 
2.1.4

[PATCH 2/2] gstreamer1.0: Make check selectable via PACKAGECONFIG

[Ricardo Ribalda Delgado]

This way, this configuration can be easily changed via .bbappend file
without having to re-define the whole EXTRA_OECONF.

With --disable-check  libgstcheck is not build.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
index 17a0d7f839c4..be8aa8f9cbb7 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
@@ -10,9 +10,10 @@ DEPENDS = "glib-2.0 libxml2 bison-native flex-native"
 inherit autotools pkgconfig gettext
 
 PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"
+PACKAGECONFIG[check] = "--enable-check,--disable-check"
 
 EXTRA_OECONF = "--disable-docbook --disable-gtk-doc \
-                --disable-dependency-tracking --disable-check \
+                --disable-dependency-tracking \
                 --disable-examples --disable-tests \
                 --disable-valgrind \
                 "
-- 
2.1.4

Re: [PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG

[Andre McCurdy]

On Fri, May 8, 2015 at 8:04 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> It is more elegant

For gstreamer 0.10, it was possible to enable debug for gstreamer and
most gstreamer plug-ins by over-riding a single variable,
GSTREAMER_DEBUG.

It might be nice if gstreamer 1.x allowed a similar approach. For that
to happen, it looks like:

 - Leave GSTREAMER_1_DEBUG as a variable in gstreamer1.0.inc
 - Rename GSTREAMER_1_0_DEBUG -> GSTREAMER_1_DEBUG in gstreamer1.0-plugins.inc

Or perhaps even use the "GSTREAMER_DEBUG" variable in gstreamer 1.x recipes?

>
> Suggested-by: Ross Burton <ross.burton@intel.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>  meta/recipes-multimedia/gstreamer/gstreamer1.0.inc | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
> index a01c33ce5ff9..17a0d7f839c4 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
> @@ -9,11 +9,12 @@ DEPENDS = "glib-2.0 libxml2 bison-native flex-native"
>
>  inherit autotools pkgconfig gettext
>
> -GSTREAMER_1_DEBUG ?= "--disable-debug"
> +PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"
> +
>  EXTRA_OECONF = "--disable-docbook --disable-gtk-doc \
>                  --disable-dependency-tracking --disable-check \
>                  --disable-examples --disable-tests \
> -                --disable-valgrind ${GSTREAMER_1_DEBUG} \
> +                --disable-valgrind \
>                  "
>
>  RRECOMMENDS_${PN}_qemux86    += "kernel-module-snd-ens1370 kernel-module-snd-rawmidi"
> --
> 2.1.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG

[Otavio Salvador]

On Fri, May 8, 2015 at 4:07 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
...
> Or perhaps even use the "GSTREAMER_DEBUG" variable in gstreamer 1.x recipes?

I think the PACKAGECONFIG is a nice compromise as it allows for
granular control over what to enable or not. It is easy to enable it
for recipes in a local.conf using pn-<package>_append or similar.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG

[Andre McCurdy]

On Fri, May 8, 2015 at 12:12 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Fri, May 8, 2015 at 4:07 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> ...
>> Or perhaps even use the "GSTREAMER_DEBUG" variable in gstreamer 1.x recipes?
>
> I think the PACKAGECONFIG is a nice compromise as it allows for
> granular control over what to enable or not. It is easy to enable it
> for recipes in a local.conf using pn-<package>_append or similar.

Over-riding GSTREAMER_DEBUG could be done on a per-package basis too,
if there's really a need to enable debugging selectively.

However, I guess when you want to enable gstreamer debugging, you
typically want to do so through-out gstreamer and all plug-ins... and
needing to control PACKAGECONFIG for each recipe makes it harder to do
that.

Whatever happens, the GSTREAMER_DEBUG, GSTREAMER_1_DEBUG and
GSTREAMER_1_0_DEBUG duplication should probably be fixed.

I don't have a strong preference though and I'm stuck partnered with
an SoC vendor who only supports Gtreamer 0.10, so I'll be watching
from the sidelines as everyone else debugs GStreamer 1.x in oe-core
:-(

> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG

[Richard Purdie]

On Fri, 2015-05-08 at 13:35 -0700, Andre McCurdy wrote:
> On Fri, May 8, 2015 at 12:12 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
> > On Fri, May 8, 2015 at 4:07 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> > ...
> >> Or perhaps even use the "GSTREAMER_DEBUG" variable in gstreamer 1.x recipes?
> >
> > I think the PACKAGECONFIG is a nice compromise as it allows for
> > granular control over what to enable or not. It is easy to enable it
> > for recipes in a local.conf using pn-<package>_append or similar.
> 
> Over-riding GSTREAMER_DEBUG could be done on a per-package basis too,
> if there's really a need to enable debugging selectively.
> 
> However, I guess when you want to enable gstreamer debugging, you
> typically want to do so through-out gstreamer and all plug-ins... and
> needing to control PACKAGECONFIG for each recipe makes it harder to do
> that.
> 
> Whatever happens, the GSTREAMER_DEBUG, GSTREAMER_1_DEBUG and
> GSTREAMER_1_0_DEBUG duplication should probably be fixed.
> 
> I don't have a strong preference though and I'm stuck partnered with
> an SoC vendor who only supports Gtreamer 0.10, so I'll be watching
> from the sidelines as everyone else debugs GStreamer 1.x in oe-core
> :-(

I took the patch since I do think PACKAGECONFIG is an improvement for
this. We could build upon it with something like:

GSTREAMER_CONFIG = ""
PACKAGECONFIG ??= "${GSTREAMER_CONFIG}"

then setting GSTREAMER_CONFIG = "debug" could do what you describe if
there really is the demand for it.

Cheers,

Richard

Re: [PATCH 1/2] gstreamer1.0: convert GSTREAMER_1_DEBUG to PACKAGECONFIG

[Ricardo Ribalda Delgado]

Hello

On Sun, May 10, 2015 at 12:00 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:

>
> GSTREAMER_CONFIG = ""

= or ?=

> PACKAGECONFIG ??= "${GSTREAMER_CONFIG}"
>
> then setting GSTREAMER_CONFIG = "debug" could do what you describe if
> there really is the demand for it.

Shall I send a patch to fix it also on plugins?

Thanks

-- 
Ricardo Ribalda