Re: [PATCH V3 3/3] systemd: split modules into packages

["Bottazzini, Bruno" <bruno.bottazzini@intel.com>]

On Seg, 2015-05-11 at 08:06 +0200, Anders Darander wrote:
> * Bottazzini, Bruno <bruno.bottazzini@intel.com> [150508 00:46]:
> 
> > On Qui, 2015-05-07 at 20:58 +0200, Andreas Oberritter wrote:
> > > On 07.05.2015 18:40, Bruno Bottazzini wrote:
> > > > +                   vconsole \
> > > > +                   update \
> > > > +                   timesyncd \
> > > > +                   rfkill \
> > > > +                   quota \
> > > > +                   fuse \
> > > > +                   firstboot \
> > > > +                   dbus \
> > > > +                   binfmt \
> > > > +                   backlight \
> > > > +                   ask-password \
> 
> > > I think it may be better to sort this quite long list alphabetically.
> 
> > > Are these options already enabled today? 
> 
> > Yes, it is enabled. 
> 
> > This is the default packages enabled in the current recipe.
> 
> > > Because of the new
> > > packageconfig entries, I would have expected changes to EXTRA_OECONF and
> > > DEPENDS, which I don't see in your patch.
> 
> > Some packages does not have EXTRA_OECONF.
> 
> > You can see what this recipe DEPENDS by looking at ${PN}-services-base.
> 
> What Andreas is asking about, is e.g. for the kmod PACKAGECONFIG:
> 
> > > > +PACKAGECONFIG[kmod] = "--enable-kmod,--disable-kmod,kmod"
> 
> Here, if kmod is enabled in PACKAGECONFIG, kmod (the 3rd parameter),
> will be added to DEPENDS. Thus, you should remove kmod from the static
> DEPENDS (as now it's dynamically added using PACKAGECONFIGS).

You're right. I will make DEPENDS to be dynamically too.

> 
> The same is likely true for a number of the other PACKAGECONFIGs that
> you're adding (which, by the way is a _good_ thing to add).

Yeap! I will check the others

Thanks

> 
> Cheers,
> Anders
>