Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V3 2/3] systemd: Verify if journal-flush.service exists.
Date: Thu, 07 May 2015 20:49:53 +0200	[thread overview]
Message-ID: <554BB3D1.8050508@opendreambox.org> (raw)
In-Reply-To: <1431016840-26287-3-git-send-email-bruno.bottazzini@intel.com>

Hello Bruno,

On 07.05.2015 18:40, Bruno Bottazzini wrote:
> If the users wants to enable networkd this file will not be generate and the
> installation will fail.
> 
> Signed-off-by: Bruno Bottazzini <bruno.bottazzini@intel.com>
> ---
>  meta/recipes-core/systemd/systemd_219.bb | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_219.bb b/meta/recipes-core/systemd/systemd_219.bb
> index c196017..b4bff18 100644
> --- a/meta/recipes-core/systemd/systemd_219.bb
> +++ b/meta/recipes-core/systemd/systemd_219.bb
> @@ -177,8 +177,11 @@ do_install() {
>  	sed -i -e 's/.*ForwardToSyslog.*/ForwardToSyslog=yes/' ${D}${sysconfdir}/systemd/journald.conf
>  	# its needed in 216 upstream has fixed it with 919699ec301ea507edce4a619141ed22e789ac0d
>  	# don't order journal flushing afte remote-fs.target
> -	sed -i -e 's/ remote-fs.target$//' ${D}${systemd_unitdir}/system/systemd-journal-flush.service
> -	# this file is needed to exist if networkd is disabled but timesyncd is still in use since timesyncd checks it
> +	if [ -s ${D}${systemd_unitdir}/system/systemd-journal-flush.service ]; then
> +                # this file is needed to exist if networkd is disabled but timesyncd is still in use since timesyncd checks it
> +                sed -i -e 's/ remote-fs.target$//' ${D}${systemd_unitdir}/system/systemd-journal-flush.service
> +        fi
> +

According to the comment above, this is a workaround specific to 216.
Commit 919699ec301ea507edce4a619141ed22e789ac0d made it into 218. So
maybe these lines should just get removed.

Regards,
Andreas


  reply	other threads:[~2015-05-07 18:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 16:40 [PATCH V3 0/3] systemd: split modules into packages Bruno Bottazzini
2015-05-07 16:40 ` [PATCH V3 1/3] dbus: split tools package Bruno Bottazzini
2015-05-07 16:40 ` [PATCH V3 2/3] systemd: Verify if journal-flush.service exists Bruno Bottazzini
2015-05-07 18:49   ` Andreas Oberritter [this message]
2015-05-07 22:19     ` Bottazzini, Bruno
2015-05-07 16:40 ` [PATCH V3 3/3] systemd: split modules into packages Bruno Bottazzini
2015-05-07 18:58   ` Andreas Oberritter
2015-05-07 22:45     ` Bottazzini, Bruno
2015-05-11  6:06       ` Anders Darander
2015-05-11 14:04         ` Bottazzini, Bruno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554BB3D1.8050508@opendreambox.org \
    --to=obi@opendreambox.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox