Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/2] testimage: Support full TC path such oeqa.runtime.pnp.get_memory_size in TEST_SUITES
@ 2015-06-23  7:54 zjh
  2015-07-02  1:52 ` Shen, Cathy
  0 siblings, 1 reply; 3+ messages in thread
From: zjh @ 2015-06-23  7:54 UTC (permalink / raw)
  To: openembedded-core

https://bugzilla.yoctoproject.org/show_bug.cgi?id=7834

If a TC name start with "oeqa", it is thought as a full TC path. if not,
follow original logic (assume under oeqa.runtime), and this case will be    7 load by loadTests.
for example:
TEST_SUITES = "oeqa.runtime.pnp.get_memory_size oeqa.runtime.sanity.reboot"
this will run these two case when bitbake -c testimage

Signed-off-by: zjh <junhuix.zhang@intel.com>
---
 meta/classes/testimage.bbclass | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
index 4074ff7..5d74fe4 100644
--- a/meta/classes/testimage.bbclass
+++ b/meta/classes/testimage.bbclass
@@ -77,6 +77,9 @@ def get_tests_list(d, type="runtime"):
     testslist = []
     for testname in testsuites:
         if testname != "auto":
+            if testname.startswith("oeqa."):
+                testslist.append(testname)
+                continue
             found = False
             for p in bbpath:
                 if os.path.exists(os.path.join(p, 'lib', 'oeqa', type, testname + '.py')):
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] testimage: Support full TC path such oeqa.runtime.pnp.get_memory_size in TEST_SUITES
  2015-06-23  7:54 [PATCH 1/2] testimage: Support full TC path such oeqa.runtime.pnp.get_memory_size in TEST_SUITES zjh
@ 2015-07-02  1:52 ` Shen, Cathy
  2015-07-08 15:24   ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Shen, Cathy @ 2015-07-02  1:52 UTC (permalink / raw)
  To: Zhang, JunhuiX, openembedded-core@lists.openembedded.org

Are we OK with this patch?

-Cathy

>-----Original Message-----
>From: openembedded-core-bounces@lists.openembedded.org
>[mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of zjh
>Sent: Tuesday, June 23, 2015 3:54 PM
>To: openembedded-core@lists.openembedded.org
>Subject: [OE-core] [PATCH 1/2] testimage: Support full TC path such
>oeqa.runtime.pnp.get_memory_size in TEST_SUITES
>
>https://bugzilla.yoctoproject.org/show_bug.cgi?id=7834
>
>If a TC name start with "oeqa", it is thought as a full TC path. if not,
>follow original logic (assume under oeqa.runtime), and this case will be    7 load by
>loadTests.
>for example:
>TEST_SUITES = "oeqa.runtime.pnp.get_memory_size oeqa.runtime.sanity.reboot"
>this will run these two case when bitbake -c testimage
>
>Signed-off-by: zjh <junhuix.zhang@intel.com>
>---
> meta/classes/testimage.bbclass | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
>index 4074ff7..5d74fe4 100644
>--- a/meta/classes/testimage.bbclass
>+++ b/meta/classes/testimage.bbclass
>@@ -77,6 +77,9 @@ def get_tests_list(d, type="runtime"):
>     testslist = []
>     for testname in testsuites:
>         if testname != "auto":
>+            if testname.startswith("oeqa."):
>+                testslist.append(testname)
>+                continue
>             found = False
>             for p in bbpath:
>                 if os.path.exists(os.path.join(p, 'lib', 'oeqa', type, testname +
>'.py')):
>--
>1.9.1
>
>--
>_______________________________________________
>Openembedded-core mailing list
>Openembedded-core@lists.openembedded.org
>http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] testimage: Support full TC path such oeqa.runtime.pnp.get_memory_size in TEST_SUITES
  2015-07-02  1:52 ` Shen, Cathy
@ 2015-07-08 15:24   ` Richard Purdie
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2015-07-08 15:24 UTC (permalink / raw)
  To: Shen, Cathy; +Cc: openembedded-core@lists.openembedded.org

On Thu, 2015-07-02 at 01:52 +0000, Shen, Cathy wrote:
> Are we OK with this patch?

To be honest, I was a bit confused as it said 1/2 and there never was a
2/2 until a week later and I didn't connect the two.

For future reference, the correct way to reference bugzilla in the
commit message is:

[YOCTO #7834]

The 2/2 patch also had no explanation of what it did in the commit
message body.

I've tweaked the commit messages for these two and queued in
master-next.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-08 15:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-23  7:54 [PATCH 1/2] testimage: Support full TC path such oeqa.runtime.pnp.get_memory_size in TEST_SUITES zjh
2015-07-02  1:52 ` Shen, Cathy
2015-07-08 15:24   ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox