Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/1] rpcbind: handle rpcbind options
@ 2015-07-10  5:36 wenzong.fan
  2015-07-10 14:16 ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: wenzong.fan @ 2015-07-10  5:36 UTC (permalink / raw)
  To: openembedded-core

From: Li Wang <li.wang@windriver.com>

the patch refers to:
https://bugs.launchpad.net/ubuntu/+source/rpcbind/+bug/835833

Run test:
$ systemctl restart rpcbind
$ systemctl status rpcbind

Signed-off-by: Li Wang <li.wang@windriver.com>
---
 meta/recipes-extended/rpcbind/rpcbind/rpcbind.service | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-extended/rpcbind/rpcbind/rpcbind.service b/meta/recipes-extended/rpcbind/rpcbind/rpcbind.service
index b3ae254..24836d4 100644
--- a/meta/recipes-extended/rpcbind/rpcbind/rpcbind.service
+++ b/meta/recipes-extended/rpcbind/rpcbind/rpcbind.service
@@ -4,8 +4,8 @@ Requires=rpcbind.socket
 
 [Service]
 Type=forking
-EnvironmentFile=-@SYSCONFDIR@/rpcbind.conf
-ExecStart=@SBINDIR@/rpcbind -w $RPCBIND_OPTS
+EnvironmentFile=@SYSCONFDIR@/rpcbind.conf
+ExecStart=@SBINDIR@/rpcbind $RPCBIND_OPTS
 SuccessExitStatus=2
 
 [Install]
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] rpcbind: handle rpcbind options
  2015-07-10  5:36 [PATCH 1/1] rpcbind: handle rpcbind options wenzong.fan
@ 2015-07-10 14:16 ` Richard Purdie
  2015-07-13  5:33   ` wenzong fan
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2015-07-10 14:16 UTC (permalink / raw)
  To: wenzong.fan; +Cc: openembedded-core

On Fri, 2015-07-10 at 13:36 +0800, wenzong.fan@windriver.com wrote:
> From: Li Wang <li.wang@windriver.com>
> 
> the patch refers to:
> https://bugs.launchpad.net/ubuntu/+source/rpcbind/+bug/835833
> 
> Run test:
> $ systemctl restart rpcbind
> $ systemctl status rpcbind


I shouldn't have to follow a link to figure out what the patch is for,
why or how. Please improve the commit message.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] rpcbind: handle rpcbind options
  2015-07-10 14:16 ` Richard Purdie
@ 2015-07-13  5:33   ` wenzong fan
  0 siblings, 0 replies; 3+ messages in thread
From: wenzong fan @ 2015-07-13  5:33 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

On 07/10/2015 10:16 PM, Richard Purdie wrote:
> On Fri, 2015-07-10 at 13:36 +0800, wenzong.fan@windriver.com wrote:
>> From: Li Wang <li.wang@windriver.com>
>>
>> the patch refers to:
>> https://bugs.launchpad.net/ubuntu/+source/rpcbind/+bug/835833
>>
>> Run test:
>> $ systemctl restart rpcbind
>> $ systemctl status rpcbind
>
>
> I shouldn't have to follow a link to figure out what the patch is for,
> why or how. Please improve the commit message.

Ok, I have updated the commit message and re-sent V2 both for:

[OE-core] [PATCH 1/1 v2] rpcbind: handle rpcbind options
[OE-core] [PATCH 1/1 v2] netbase: add rpcbind as an alias to sunrpc

Thanks
Wenzong

>
> Cheers,
>
> Richard
>
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-13  5:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-10  5:36 [PATCH 1/1] rpcbind: handle rpcbind options wenzong.fan
2015-07-10 14:16 ` Richard Purdie
2015-07-13  5:33   ` wenzong fan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox