[scripts][PATCH] yocto-layer: Stops duplication of "meta-" prefix

[scripts][PATCH] yocto-layer: Stops duplication of "meta-" prefix

[humberto.ibarra.lopez]

From: Humberto Ibarra <humberto.ibarra.lopez@intel.com>

The yocto-layer script puts an extra "meta-" prefix to the given layer
name even when the prefix is already there. This fix avoids
duplicating the prefix in these situations.

[YOCTO #8050]

Signed-off-by: Humberto Ibarra <humberto.ibarra.lopez@intel.com>
---
 scripts/yocto-layer | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/yocto-layer b/scripts/yocto-layer
index 53d2aab..0dbbf3b 100755
--- a/scripts/yocto-layer
+++ b/scripts/yocto-layer
@@ -74,6 +74,8 @@ def yocto_layer_create_subcommand(args, usage_str):
 
     if options.outdir:
         layer_output_dir = options.outdir
+    elif layer_name.startswith("meta-"):
+        layer_output_dir = layer_name
     else:
         layer_output_dir = "meta-" + layer_name
 
-- 
1.9.1

Re: [scripts][PATCH] yocto-layer: Stops duplication of "meta-" prefix

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

On 29 July 2015 at 20:50, <humberto.ibarra.lopez@intel.com> wrote:

> The yocto-layer script puts an extra "meta-" prefix to the given layer
> name even when the prefix is already there. This fix avoids
> duplicating the prefix in these situations.
>

If the scripts expects the layer name to not have a meta- prefix, should it
also strip a prefix if its present before passing it to
yocto_layer_create()?

Ross

[-- Attachment #2: Type: text/html, Size: 832 bytes --]

Re: [scripts][PATCH] yocto-layer: Stops duplication of "meta-" prefix

[Benjamin Esquivel]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

On Thu, 2015-07-30 at 14:28 +0100, Burton, Ross wrote:
> 
> On 29 July 2015 at 20:50, <humberto.ibarra.lopez@intel.com> wrote:
> > The yocto-layer script puts an extra "meta-" prefix to the given
> > layer
> > name even when the prefix is already there. This fix avoids
> > duplicating the prefix in these situations.
> > 
> If the scripts expects the layer name to not have a meta- prefix,
> should it also strip a prefix if its present before passing it to
> yocto_layer_create()?
I'm failing to understand the question, I think the
yocto_layer_create() is receiving a layer_output_dir argument with
'meta-' checked to not be duplicated.  The fix is right above the
yocto_layer_create() call.
> Ross

> -- 
> _______________________________________________
> Openembedded-core mailing list
> 
Openembedded-core@lists.openembedded.org> 
http://lists.openembedded.org/mailman/listinfo/openembedded-core> 

[-- Attachment #2: Type: text/html, Size: 1569 bytes --]

Re: [scripts][PATCH] yocto-layer: Stops duplication of "meta-" prefix

[Ibarra Lopez, Humberto]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

I didn’t see any more comments regarding this, are there any updates? I am not entirely sure about Ross’ question either.


From: Benjamin Esquivel [mailto:benjamin.esquivel@linux.intel.com]
Sent: Thursday, July 30, 2015 10:59 AM
To: Burton, Ross; Ibarra Lopez, Humberto
Cc: OE-core
Subject: Re: [OE-core] [scripts][PATCH] yocto-layer: Stops duplication of "meta-" prefix

On Thu, 2015-07-30 at 14:28 +0100, Burton, Ross wrote:

On 29 July 2015 at 20:50, <humberto.ibarra.lopez@intel.com<mailto:humberto.ibarra.lopez@intel.com>> wrote:

The yocto-layer script puts an extra "meta-" prefix to the given layer
name even when the prefix is already there. This fix avoids
duplicating the prefix in these situations.


If the scripts expects the layer name to not have a meta- prefix, should it also strip a prefix if its present before passing it to yocto_layer_create()?
I'm failing to understand the question, I think the yocto_layer_create() is receiving a layer_output_dir argument with 'meta-' checked to not be duplicated.  The fix is right above the yocto_layer_create() call.
Ross

--

_______________________________________________

Openembedded-core mailing list

Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>

http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 5273 bytes --]