[PATCH] runqemu: Add error handling for unexpected tap devices

[PATCH] runqemu: Add error handling for unexpected tap devices

[Richard Purdie]

In theory the code reduces the tap device number to an integer. This
patch adds error checking to ensure that does happen and that the script
exits if something unexpected happens.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
index 03b40d8..0ace485 100755
--- a/scripts/runqemu-internal
+++ b/scripts/runqemu-internal
@@ -253,6 +253,14 @@ else
 
 
         n0=$(echo $TAP | sed 's/tap//')
+
+        case $n0 in
+            ''|*[!0-9]*)
+                echo "Error Couldn't turn $TAP into an interface number?"
+                exit 1
+                ;;
+        esac
+
         n1=$(($n0 * 2 + 1))
         n2=$(($n1 + 1))
 

Re: [PATCH] runqemu: Add error handling for unexpected tap devices

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]


> On Aug 9, 2015, at 12:03 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> 
> In theory the code reduces the tap device number to an integer. This
> patch adds error checking to ensure that does happen and that the script
> exits if something unexpected happens.
> 

I see these patches are already on master. Are you sending them again by mistake for review or something else ?

> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
> index 03b40d8..0ace485 100755
> --- a/scripts/runqemu-internal
> +++ b/scripts/runqemu-internal
> @@ -253,6 +253,14 @@ else
> 
> 
>         n0=$(echo $TAP | sed 's/tap//')
> +
> +        case $n0 in
> +            ''|*[!0-9]*)
> +                echo "Error Couldn't turn $TAP into an interface number?"
> +                exit 1
> +                ;;
> +        esac
> +
>         n1=$(($n0 * 2 + 1))
>         n2=$(($n1 + 1))
> 
> 
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH] runqemu: Add error handling for unexpected tap devices

[Richard Purdie]

On Sun, 2015-08-09 at 00:31 -0700, Khem Raj wrote:
> > On Aug 9, 2015, at 12:03 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> > 
> > In theory the code reduces the tap device number to an integer. This
> > patch adds error checking to ensure that does happen and that the script
> > exits if something unexpected happens.
> > 
> 
> I see these patches are already on master. Are you sending them again by mistake for review or something else ?

Sorry, I've hit the wrong commands. The plan was to queue them for a
fast turnaround into master once the current build completed and they'd
spent some time on the list for review. It looks like I pushed them
early :/.

The good news is that with these patches, one of the "random" issues
we've been seeing is fixed and we might be able to start trusting the
autobuilder a bit more again. There are still other issues but this is
perhaps the one with the most visible impact.

It does look like we're going to need an M2 rc2 once we figure out the
libpam issues so I'm going to hold off the various queued upgrades until
we figure out a good rc2 build combination of changes.

Cheers,

Richard