From: Patrick Ohly <patrick.ohly@intel.com>
To: Andrea Adami <andrea.adami@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl
Date: Tue, 25 Aug 2015 17:29:58 +0200 [thread overview]
Message-ID: <1440516598.24929.81.camel@intel.com> (raw)
In-Reply-To: <1440280746-11401-1-git-send-email-andrea.adami@gmail.com>
On Sat, 2015-08-22 at 23:59 +0200, Andrea Adami wrote:
> After commit 24fde4d do_compile fails:
>
> | mkfs.jffs2.c:70:21: fatal error: sys/acl.h: No such file or directory
> | #include <sys/acl.h>
>
> This is a missing dependency on acl.
> To fix this we add a check to disable xattr when acl is not in
> DISTRO_FEATURES.
I'm unsure whether checking for acl is the right approach. If "xattr"
was added to DISTRO_FEATURES, I'd expect the xattr support in mtd-utils
to be enabled, even if that creates some additional dependencies.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2015-08-25 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 21:59 [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl Andrea Adami
2015-08-25 15:29 ` Patrick Ohly [this message]
2015-08-26 9:50 ` Huang, Jie (Jackie)
2015-08-26 16:03 ` Patrick Ohly
2015-08-26 16:10 ` [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency Patrick Ohly
2015-08-26 16:42 ` Mark Hatle
2015-08-26 19:02 ` Andre McCurdy
2015-08-27 6:45 ` Patrick Ohly
2015-08-26 19:16 ` Khem Raj
2015-08-27 6:43 ` Patrick Ohly
2015-08-27 13:32 ` Khem Raj
2015-08-27 14:07 ` Patrick Ohly
2015-08-27 3:33 ` [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl Huang, Jie (Jackie)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440516598.24929.81.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=andrea.adami@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox