Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency
Date: Thu, 27 Aug 2015 08:45:20 +0200	[thread overview]
Message-ID: <1440657920.20082.28.camel@intel.com> (raw)
In-Reply-To: <CAJ86T=WnRNNrh9kr7QfHtP-tqmxdtZ1qm-0mnsAA1ANW04qysA@mail.gmail.com>

On Wed, 2015-08-26 at 12:02 -0700, Andre McCurdy wrote:
> On Wed, Aug 26, 2015 at 9:10 AM, Patrick Ohly <patrick.ohly@intel.com> wrote:
> > The unconditional removal of -DWITHOUT_XATTR accidentally introduced a
> > compile-time dependency on "acl", because "sys/acl.h" gets
> > included. This caused random compile failures.
> >
> > To fix this, we introduce a proper PACKAGECONFIG for the "xattr"
> > support, with the distro's "xattr" feature determining the
> > default. Setting the define must be done with custom code because
> > PACKAGECONFIG can only influence configure parameters.
> >
> > The "acl" distro feature is not checked because although enabling
> > "xattr" support now triggers a build of acl, nothing from it will not
> > get included in the resulting target image.
> 
> Typo?

Yes, the "not" needs to be removed. Can whoever merges the patch fix
that or should I send a revised version?

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.





  reply	other threads:[~2015-08-27  6:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-22 21:59 [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl Andrea Adami
2015-08-25 15:29 ` Patrick Ohly
2015-08-26  9:50 ` Huang, Jie (Jackie)
2015-08-26 16:03   ` Patrick Ohly
2015-08-26 16:10     ` [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency Patrick Ohly
2015-08-26 16:42       ` Mark Hatle
2015-08-26 19:02       ` Andre McCurdy
2015-08-27  6:45         ` Patrick Ohly [this message]
2015-08-26 19:16       ` Khem Raj
2015-08-27  6:43         ` Patrick Ohly
2015-08-27 13:32           ` Khem Raj
2015-08-27 14:07             ` Patrick Ohly
2015-08-27  3:33     ` [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl Huang, Jie (Jackie)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440657920.20082.28.camel@intel.com \
    --to=patrick.ohly@intel.com \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox