Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] sanity.bbclass: remove forced abspath for SSTATE_MIRRORS
@ 2015-08-26  4:32 Christopher Larson
  2015-08-26  4:35 ` [PATCHv2] " Christopher Larson
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Larson @ 2015-08-26  4:32 UTC (permalink / raw)
  To: openembedded-core; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

The sstate URI is relative to begin with, so it's completely valid to want to
alter it in a way that keeps it relative using a mirror, and I have real world
cases where this is causing issues. Remove the check which errors out on
relative file:// paths.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta/classes/sanity.bbclass | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index ef90fc8..c142274 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -818,8 +818,6 @@ def check_sanity_everybuild(status, d):
                 continue
 
             if mirror.startswith('file://'):
-                if not mirror.startswith('file:///'):
-                    bb.warn('Invalid file url in %s: %s, must be absolute path (file:///)' % (mirror_var, mirror_entry))
                 import urlparse
                 check_symlink(urlparse.urlparse(mirror).path, d)
                 # SSTATE_MIRROR ends with a /PATH string
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCHv2] sanity.bbclass: remove forced abspath for SSTATE_MIRRORS
  2015-08-26  4:32 [PATCH] sanity.bbclass: remove forced abspath for SSTATE_MIRRORS Christopher Larson
@ 2015-08-26  4:35 ` Christopher Larson
  2015-08-26  4:41   ` [PATCHv3] sanity.bbclass: remove abspath warning " Christopher Larson
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Larson @ 2015-08-26  4:35 UTC (permalink / raw)
  To: openembedded-core; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

The sstate URI is relative to begin with, so it's completely valid to want to
alter it in a way that keeps it relative using a mirror, and I have real world
cases where this is causing issues. Remove the check which warns on relative
file:// paths.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta/classes/sanity.bbclass | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index ef90fc8..c142274 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -818,8 +818,6 @@ def check_sanity_everybuild(status, d):
                 continue
 
             if mirror.startswith('file://'):
-                if not mirror.startswith('file:///'):
-                    bb.warn('Invalid file url in %s: %s, must be absolute path (file:///)' % (mirror_var, mirror_entry))
                 import urlparse
                 check_symlink(urlparse.urlparse(mirror).path, d)
                 # SSTATE_MIRROR ends with a /PATH string
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCHv3] sanity.bbclass: remove abspath warning for SSTATE_MIRRORS
  2015-08-26  4:35 ` [PATCHv2] " Christopher Larson
@ 2015-08-26  4:41   ` Christopher Larson
  0 siblings, 0 replies; 3+ messages in thread
From: Christopher Larson @ 2015-08-26  4:41 UTC (permalink / raw)
  To: openembedded-core; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

The sstate URI is relative to begin with, so it's completely valid to want to
alter it in a way that keeps it relative using a mirror, and I have real world
cases where this is causing issues. Remove the warning.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta/classes/sanity.bbclass | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index ef90fc8..c142274 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -818,8 +818,6 @@ def check_sanity_everybuild(status, d):
                 continue
 
             if mirror.startswith('file://'):
-                if not mirror.startswith('file:///'):
-                    bb.warn('Invalid file url in %s: %s, must be absolute path (file:///)' % (mirror_var, mirror_entry))
                 import urlparse
                 check_symlink(urlparse.urlparse(mirror).path, d)
                 # SSTATE_MIRROR ends with a /PATH string
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-26  4:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-26  4:32 [PATCH] sanity.bbclass: remove forced abspath for SSTATE_MIRRORS Christopher Larson
2015-08-26  4:35 ` [PATCHv2] " Christopher Larson
2015-08-26  4:41   ` [PATCHv3] sanity.bbclass: remove abspath warning " Christopher Larson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox