[PATCH 0/1] v3: pseudo 1.7.2

[PATCH 0/1] v3: pseudo 1.7.2

[Peter Seebach]

So the opkg uprev from 0.2.4 to 0.3.0 turns out to trip on a
change I thought would be harmless, but which was also unintentional-ish.

Historically, pseudo has just assumed no one will put 0700 in umask.
With xattrdb, this can break if you have 0700 in umask, and try to open
a file, because pseudo needs to be able to write to the file in order
to store extended attributes. And I spotted that, so I added manual
chmods in cases where a file mave have been created by an open.

But I used 0600 instead of the base mode | 0600, and this resulted in
losing execute bits in some cases. This was only in the base filesystem,
and normally real filesystem execute bits on things in the target filesystem
space don't matter. But opkg 0.3.0 is now doing
	sh -c /path/to/postinst_script
and that fails if the script lacks 0100.

Whoops.

(The change there is why this didn't get caught in the previous 1.7.x
testing.)

The following changes since commit aba3ef50d65e0dc8659a48bf98d0fb00dd44a6fc:

  debianutils: create package for run-parts (2015-09-02 23:51:16 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib seebs/pseudo172
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/pseudo172

Peter Seebach (1):
  pseudo_1.7.2.bb: New version of pseudo

 meta/recipes-devtools/pseudo/pseudo_1.7.2.bb | 19 +++++++++++++++++++
 meta/recipes-devtools/pseudo/pseudo_git.bb   |  4 ++--
 2 files changed, 21 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-devtools/pseudo/pseudo_1.7.2.bb

-- 
2.3.1

[PATCH 1/1] pseudo_1.7.2.bb: New version of pseudo

[Peter Seebach]

Pseudo 1.7 adds an experimental feature (which I think needs more testing
before it becomes the default) allowing the pseudo client to store modes
and uid/gid values in extended attributes rather than using the sqlite
database. On most Linux-like systems, this works only if the underlying
file is a plain file or a directory.

Also added is a profiling feature to allow some amount of reporting on
the wall-clock time the client spends in wrappers, processing operations,
or in IPC. This feature is not intendeded to be precisely accurate, but
gives a good overview of where time is going.

Based on the results from the profiling feature, the client now suppresses
OP_OPEN and OP_EXEC messages if the server is not logging messages, and
no longer uses constant dynamic allocation and free cycles for canonicalized
paths.

There's a few other likely-looking optimizations being considered, but
this seemed like a good cutoff for now.

1.7.1 fixes two bugs, one affecting mostly XFS systems with 64-bit
inode values, and one affecting code that called realpath(x, NULL), such
as the RPM backend.

1.7.2 fixes an indirect side-effect of the chmod fixes to deal with
umask 0700, which had no effect with opkg 0.2.4 but appears to cause
failures with 0.3.0.

Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
---
 meta/recipes-devtools/pseudo/pseudo_1.7.2.bb | 19 +++++++++++++++++++
 meta/recipes-devtools/pseudo/pseudo_git.bb   |  4 ++--
 2 files changed, 21 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-devtools/pseudo/pseudo_1.7.2.bb

diff --git a/meta/recipes-devtools/pseudo/pseudo_1.7.2.bb b/meta/recipes-devtools/pseudo/pseudo_1.7.2.bb
new file mode 100644
index 0000000..57704a2
--- /dev/null
+++ b/meta/recipes-devtools/pseudo/pseudo_1.7.2.bb
@@ -0,0 +1,19 @@
+require pseudo.inc
+
+SRC_URI = " \
+    http://downloads.yoctoproject.org/releases/pseudo/${BPN}-${PV}.tar.bz2 \
+    file://fallback-passwd \
+    file://fallback-group \
+"
+
+SRC_URI[md5sum] = "a293a0b38fca6efc9313af24a7cfa369"
+SRC_URI[sha256sum] = "f0c4fbd7b19622648bfee66bdfcbfc66de6e63d3ec601ca1922b1839143a2f11"
+
+PSEUDO_EXTRA_OPTS ?= "--enable-force-async --without-passwd-fallback"
+
+do_install_append_class-native () {
+	install -d ${D}${sysconfdir}
+	# The fallback files should never be modified
+	install -m 444 ${WORKDIR}/fallback-passwd ${D}${sysconfdir}/passwd
+	install -m 444 ${WORKDIR}/fallback-group ${D}${sysconfdir}/group
+}
diff --git a/meta/recipes-devtools/pseudo/pseudo_git.bb b/meta/recipes-devtools/pseudo/pseudo_git.bb
index aa315d3..31e1223 100644
--- a/meta/recipes-devtools/pseudo/pseudo_git.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_git.bb
@@ -1,7 +1,7 @@
 require pseudo.inc
 
-SRCREV = "db758fb11167c79d9682a17d359568e2a3c4acd5"
-PV = "1.6.5+git${SRCPV}"
+SRCREV = "e795df44a90a426a76b790f1b2774f3046a8fc31"
+PV = "1.7.2+git${SRCPV}"
 
 DEFAULT_PREFERENCE = "-1"
 
-- 
2.3.1

Re: [PATCH 1/1] pseudo_1.7.2.bb: New version of pseudo

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

On 4 September 2015 at 04:28, Peter Seebach <peter.seebach@windriver.com>
wrote:

> +SRC_URI = " \
> +    http://downloads.yoctoproject.org/releases/pseudo
> /${BPN}-${PV}.tar.bz2 \
>

ERROR: Fetcher failure: Fetch command failed with exit code 8, output:
http://downloads.yoctoproject.org/releases/pseudo/pseudo-1.7.2.tar.bz2:
2015-09-04 14:11:21 ERROR 404: Not Found.

There isn't a 1.7.2 tarball uploaded yet.

Ross

[-- Attachment #2: Type: text/html, Size: 1290 bytes --]

Re: [PATCH 1/1] pseudo_1.7.2.bb: New version of pseudo

[Richard Purdie]

On Fri, 2015-09-04 at 14:19 +0100, Burton, Ross wrote:
> On 4 September 2015 at 04:28, Peter Seebach
> <peter.seebach@windriver.com> wrote:
>         +SRC_URI = " \
>         +
>         http://downloads.yoctoproject.org/releases/pseudo/${BPN}-${PV}.tar.bz2 \
>
> ERROR: Fetcher failure: Fetch command failed with exit code 8, output:
> http://downloads.yoctoproject.org/releases/pseudo/pseudo-1.7.2.tar.bz2:
> 2015-09-04 14:11:21 ERROR 404: Not Found.
>
> There isn't a 1.7.2 tarball uploaded yet.

There is now...

Cheers,

Richard

Re: [PATCH 1/1] pseudo_1.7.2.bb: New version of pseudo

[Richard Purdie]

On Thu, 2015-09-03 at 22:28 -0500, Peter Seebach wrote:
> Pseudo 1.7 adds an experimental feature (which I think needs more testing
> before it becomes the default) allowing the pseudo client to store modes
> and uid/gid values in extended attributes rather than using the sqlite
> database. On most Linux-like systems, this works only if the underlying
> file is a plain file or a directory.
> 
> Also added is a profiling feature to allow some amount of reporting on
> the wall-clock time the client spends in wrappers, processing operations,
> or in IPC. This feature is not intendeded to be precisely accurate, but
> gives a good overview of where time is going.
> 
> Based on the results from the profiling feature, the client now suppresses
> OP_OPEN and OP_EXEC messages if the server is not logging messages, and
> no longer uses constant dynamic allocation and free cycles for canonicalized
> paths.
> 
> There's a few other likely-looking optimizations being considered, but
> this seemed like a good cutoff for now.
> 
> 1.7.1 fixes two bugs, one affecting mostly XFS systems with 64-bit
> inode values, and one affecting code that called realpath(x, NULL), such
> as the RPM backend.
> 
> 1.7.2 fixes an indirect side-effect of the chmod fixes to deal with
> umask 0700, which had no effect with opkg 0.2.4 but appears to cause
> failures with 0.3.0.

https://autobuilder.yoctoproject.org/main/builders/buildtools/builds/473/steps/BuildImages/logs/stdio

:(

Cheers,

Richard