[PATCH] lsb: add lsbinitscripts and util-linux rdepends

[PATCH] lsb: add lsbinitscripts and util-linux rdepends

[Alex Franco]

Building a base image such as core-image-minimal with lsb and then
attempting to source /lib/lsb/init-functions, then using the start
_daemon function (to start a daemon, such as syslogd) fails, since
/lib/lsb/init-functions use functions (incl. "daemon()") from file
/etc/init.d/functions.lsbinitscripts, which is provided by package
lsbinitscripts. Running daemon() then calls /usr/bin/mountpoint, a
binary provided by util-linux. So, both of these dependencies have
been added to: recipes-extended/lsb/lsb_4.1.bb

[YOCTO #7732]

Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>
---
 meta/recipes-extended/lsb/lsb_4.1.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
index b4ef98e..11b788f 100644
--- a/meta/recipes-extended/lsb/lsb_4.1.bb
+++ b/meta/recipes-extended/lsb/lsb_4.1.bb
@@ -6,6 +6,9 @@ PR = "r2"
 
 # lsb_release needs getopt
 RDEPENDS_${PN} += "${VIRTUAL-RUNTIME_getopt}"
+# lsb needs lsbinitscripts and util-linux
+RDEPENDS_${PN} += "lsbinitscripts \
+                   util-linux"
 
 LIC_FILES_CHKSUM = "file://README;md5=12da544b1a3a5a1795a21160b49471cf"
 
-- 
1.8.4.5

Re: [PATCH] lsb: add lsbinitscripts and util-linux rdepends

[Richard Tollerton]

Alex Franco <alejandro.franco@linux.intel.com> writes:

> Building a base image such as core-image-minimal with lsb and then
> attempting to source /lib/lsb/init-functions, then using the start
> _daemon function (to start a daemon, such as syslogd) fails, since
> /lib/lsb/init-functions use functions (incl. "daemon()") from file
> /etc/init.d/functions.lsbinitscripts, which is provided by package
> lsbinitscripts. Running daemon() then calls /usr/bin/mountpoint, a
> binary provided by util-linux. So, both of these dependencies have
> been added to: recipes-extended/lsb/lsb_4.1.bb

This line wrapping is... weird. :F

> [YOCTO #7732]

I can no longer reproduce the segfault I alluded to in that bug report;
I guess I'll reopen it later if I see it again.

> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -6,6 +6,9 @@ PR = "r2"
>  
>  # lsb_release needs getopt
>  RDEPENDS_${PN} += "${VIRTUAL-RUNTIME_getopt}"

> +# lsb needs lsbinitscripts and util-linux

Nitpick: does this comment accomplish anything?

> +RDEPENDS_${PN} += "lsbinitscripts \
> +                   util-linux"

Shouldn't the util-linux dependency exist in lsbinitscripts instead of
lsb?

There's also a bash dependency in /etc/init.d/functions.lsbinitscripts
that probably needs to get added, or a patch created to eliminate it.
Should I file a new bug about it?

Re: [PATCH] lsb: add lsbinitscripts and util-linux rdepends

[Otavio Salvador]

On Wed, Sep 9, 2015 at 4:56 PM, Alex Franco
<alejandro.franco@linux.intel.com> wrote:
> Building a base image such as core-image-minimal with lsb and then
> attempting to source /lib/lsb/init-functions, then using the start
> _daemon function (to start a daemon, such as syslogd) fails, since
> /lib/lsb/init-functions use functions (incl. "daemon()") from file
> /etc/init.d/functions.lsbinitscripts, which is provided by package
> lsbinitscripts. Running daemon() then calls /usr/bin/mountpoint, a
> binary provided by util-linux. So, both of these dependencies have
> been added to: recipes-extended/lsb/lsb_4.1.bb
>
> [YOCTO #7732]
>
> Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>

Mountpoint should be split so you don't bring all util-linux just for this.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750