Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] libgcc.inc: package baremetal multilib libraries
@ 2015-09-14 16:22 Juro Bystricky
  2015-09-14 16:38 ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Juro Bystricky @ 2015-09-14 16:22 UTC (permalink / raw)
  To: openembedded-core; +Cc: richard.purdie

When building libgcc for baremetal cross-compilers, some files and libraries
may be built but not packaged. This patch fixes errors such as these:

ERROR: QA Issue: libgcc: Files/directories were installed but not shipped in any package:
  /usr/lib/arm-poky-eabi/4.9.3/thumb
  /usr/lib/arm-poky-eabi/4.9.3/fpu
  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a
  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o
  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o
  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o
  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a
  /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o
  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a
  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o
  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o
  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o
  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a
  /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
Please set FILES such that these items are packaged. Alternatively if they are unneeded,
avoid installing them or delete them within do_install. [installed-vs-shipped]

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
---
 meta/recipes-devtools/gcc/libgcc.inc | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/recipes-devtools/gcc/libgcc.inc b/meta/recipes-devtools/gcc/libgcc.inc
index 739adbd..95709e4 100644
--- a/meta/recipes-devtools/gcc/libgcc.inc
+++ b/meta/recipes-devtools/gcc/libgcc.inc
@@ -28,6 +28,12 @@ FILES_${PN}-dev = "\
     ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \
 "
 
+FILES_${PN}-dev_libc-baremetal = "\
+    ${base_libdir}/ \
+    ${libdir}/* \
+    ${libdir}/${TARGET_SYS}/* \
+"
+
 FILES_${PN}-dbg += "${base_libdir}/.debug/"
 
 LIBGCCBUILDTREENAME = "gcc-build-internal-"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] libgcc.inc: package baremetal multilib libraries
  2015-09-14 16:22 [PATCH] libgcc.inc: package baremetal multilib libraries Juro Bystricky
@ 2015-09-14 16:38 ` Khem Raj
  2015-09-14 19:53   ` Phil Blundell
  0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2015-09-14 16:38 UTC (permalink / raw)
  To: Juro Bystricky; +Cc: richard.purdie, openembedded-core


> On Sep 14, 2015, at 9:22 AM, Juro Bystricky <juro.bystricky@intel.com> wrote:
> 
> When building libgcc for baremetal cross-compilers, some files and libraries
> may be built but not packaged. This patch fixes errors such as these:
> 
> ERROR: QA Issue: libgcc: Files/directories were installed but not shipped in any package:
>  /usr/lib/arm-poky-eabi/4.9.3/thumb
>  /usr/lib/arm-poky-eabi/4.9.3/fpu
>  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a
>  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o
>  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o
>  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o
>  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a
>  /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o
>  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a
>  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o
>  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o
>  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o
>  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a
>  /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
> Please set FILES such that these items are packaged. Alternatively if they are unneeded,
> avoid installing them or delete them within do_install. [installed-vs-shipped]
> 
> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
> ---
> meta/recipes-devtools/gcc/libgcc.inc | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/meta/recipes-devtools/gcc/libgcc.inc b/meta/recipes-devtools/gcc/libgcc.inc
> index 739adbd..95709e4 100644
> --- a/meta/recipes-devtools/gcc/libgcc.inc
> +++ b/meta/recipes-devtools/gcc/libgcc.inc
> @@ -28,6 +28,12 @@ FILES_${PN}-dev = "\
>     ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \
> "
> 
> +FILES_${PN}-dev_libc-baremetal = "\
> +    ${base_libdir}/ \
> +    ${libdir}/* \
> +    ${libdir}/${TARGET_SYS}/* \
> +”

why not put it into libgcc-dev itself 

> +

> FILES_${PN}-dbg += "${base_libdir}/.debug/"
> 
> LIBGCCBUILDTREENAME = "gcc-build-internal-"
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] libgcc.inc: package baremetal multilib libraries
  2015-09-14 16:38 ` Khem Raj
@ 2015-09-14 19:53   ` Phil Blundell
  2015-09-15 16:23     ` Bystricky, Juro
  2015-09-21 23:21     ` [PATCH v2 0/1] libgcc: package multiple libraries Juro Bystricky
  0 siblings, 2 replies; 6+ messages in thread
From: Phil Blundell @ 2015-09-14 19:53 UTC (permalink / raw)
  To: Khem Raj; +Cc: richard.purdie, openembedded-core

On Mon, 2015-09-14 at 09:38 -0700, Khem Raj wrote:
> > On Sep 14, 2015, at 9:22 AM, Juro Bystricky <juro.bystricky@intel.com> wrote:
> > 
> > When building libgcc for baremetal cross-compilers, some files and libraries
> > may be built but not packaged. This patch fixes errors such as these:
> > 
> > ERROR: QA Issue: libgcc: Files/directories were installed but not shipped in any package:
> >  /usr/lib/arm-poky-eabi/4.9.3/thumb
> >  /usr/lib/arm-poky-eabi/4.9.3/fpu
> >  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a
> >  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o
> >  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o
> >  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o
> >  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a
> >  /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o
> >  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a
> >  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o
> >  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o
> >  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o
> >  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a
> >  /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
> > Please set FILES such that these items are packaged. Alternatively if they are unneeded,
> > avoid installing them or delete them within do_install. [installed-vs-shipped]
> > 
> > Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
> > ---
> > meta/recipes-devtools/gcc/libgcc.inc | 6 ++++++
> > 1 file changed, 6 insertions(+)
> > 
> > diff --git a/meta/recipes-devtools/gcc/libgcc.inc b/meta/recipes-devtools/gcc/libgcc.inc
> > index 739adbd..95709e4 100644
> > --- a/meta/recipes-devtools/gcc/libgcc.inc
> > +++ b/meta/recipes-devtools/gcc/libgcc.inc
> > @@ -28,6 +28,12 @@ FILES_${PN}-dev = "\
> >     ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \
> > "
> > 
> > +FILES_${PN}-dev_libc-baremetal = "\
> > +    ${base_libdir}/ \
> > +    ${libdir}/* \
> > +    ${libdir}/${TARGET_SYS}/* \
> > +”
> 
> why not put it into libgcc-dev itself 

Agreed.  I think the real issue here is nothing really to do with
baremetal, it's just that the existing FILES_${PN}-dev pattern doesn't
consider multilib for anything other than IA and mips.

p.




^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] libgcc.inc: package baremetal multilib libraries
  2015-09-14 19:53   ` Phil Blundell
@ 2015-09-15 16:23     ` Bystricky, Juro
  2015-09-21 23:21     ` [PATCH v2 0/1] libgcc: package multiple libraries Juro Bystricky
  1 sibling, 0 replies; 6+ messages in thread
From: Bystricky, Juro @ 2015-09-15 16:23 UTC (permalink / raw)
  To: Phil Blundell, Khem Raj
  Cc: Purdie, Richard, openembedded-core@lists.openembedded.org

Thanks, I see what you mean. I'll repost a new patch after I've tested it.

> -----Original Message-----
> From: Phil Blundell [mailto:pb@pbcl.net]
> Sent: Monday, September 14, 2015 12:53 PM
> To: Khem Raj
> Cc: Bystricky, Juro; Purdie, Richard; openembedded-
> core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] libgcc.inc: package baremetal multilib libraries
> 
> On Mon, 2015-09-14 at 09:38 -0700, Khem Raj wrote:
> > > On Sep 14, 2015, at 9:22 AM, Juro Bystricky <juro.bystricky@intel.com>
> wrote:
> > >
> > > When building libgcc for baremetal cross-compilers, some files and
> > > libraries may be built but not packaged. This patch fixes errors such as
> these:
> > >
> > > ERROR: QA Issue: libgcc: Files/directories were installed but not shipped
> in any package:
> > >  /usr/lib/arm-poky-eabi/4.9.3/thumb
> > >  /usr/lib/arm-poky-eabi/4.9.3/fpu
> > >  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a
> > >  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o
> > >  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o
> > >  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o
> > >  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a
> > >  /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o
> > >  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a
> > >  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o
> > >  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o
> > >  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o
> > >  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a
> > >  /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
> > > Please set FILES such that these items are packaged. Alternatively
> > > if they are unneeded, avoid installing them or delete them within
> > > do_install. [installed-vs-shipped]
> > >
> > > Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
> > > ---
> > > meta/recipes-devtools/gcc/libgcc.inc | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/meta/recipes-devtools/gcc/libgcc.inc
> > > b/meta/recipes-devtools/gcc/libgcc.inc
> > > index 739adbd..95709e4 100644
> > > --- a/meta/recipes-devtools/gcc/libgcc.inc
> > > +++ b/meta/recipes-devtools/gcc/libgcc.inc
> > > @@ -28,6 +28,12 @@ FILES_${PN}-dev = "\
> > >     ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \ "
> > >
> > > +FILES_${PN}-dev_libc-baremetal = "\
> > > +    ${base_libdir}/ \
> > > +    ${libdir}/* \
> > > +    ${libdir}/${TARGET_SYS}/* \
> > > +”
> >
> > why not put it into libgcc-dev itself
> 
> Agreed.  I think the real issue here is nothing really to do with baremetal, it's
> just that the existing FILES_${PN}-dev pattern doesn't consider multilib for
> anything other than IA and mips.
> 
> p.
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2 0/1] libgcc: package multiple libraries
  2015-09-14 19:53   ` Phil Blundell
  2015-09-15 16:23     ` Bystricky, Juro
@ 2015-09-21 23:21     ` Juro Bystricky
  2015-09-21 23:21       ` [PATCH v2] libgcc.inc: package baremetal multilib libraries Juro Bystricky
  1 sibling, 1 reply; 6+ messages in thread
From: Juro Bystricky @ 2015-09-21 23:21 UTC (permalink / raw)
  To: openembedded-core; +Cc: richard.purdie

Second attempt. This patch is a bit more invasive than the previous one, 
but based on my understanding it should not break the existing code.

Juro Bystricky (1):
  libgcc.inc: package baremetal multilib libraries

 meta/recipes-devtools/gcc/libgcc.inc | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

-- 
1.9.1



^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] libgcc.inc: package baremetal multilib libraries
  2015-09-21 23:21     ` [PATCH v2 0/1] libgcc: package multiple libraries Juro Bystricky
@ 2015-09-21 23:21       ` Juro Bystricky
  0 siblings, 0 replies; 6+ messages in thread
From: Juro Bystricky @ 2015-09-21 23:21 UTC (permalink / raw)
  To: openembedded-core; +Cc: richard.purdie

When building libgcc some files and libraries may be built but not packaged.
The original code packaged only some explicitly specified files targeting mostly x86.
This patch does not discriminate between various targets.
It fixes errors such as these:

ERROR: QA Issue: libgcc: Files/directories were installed but not shipped in any package:
  /usr/lib/arm-poky-eabi/4.9.3/thumb
  /usr/lib/arm-poky-eabi/4.9.3/fpu
  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a
  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o
  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o
  /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o
  /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a
  /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o
  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a
  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o
  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o
  /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o
  /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a
  /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
Please set FILES such that these items are packaged. Alternatively if they are unneeded,
avoid installing them or delete them within do_install. [installed-vs-shipped]

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
---
 meta/recipes-devtools/gcc/libgcc.inc | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/meta/recipes-devtools/gcc/libgcc.inc b/meta/recipes-devtools/gcc/libgcc.inc
index 739adbd..95fa3f4 100644
--- a/meta/recipes-devtools/gcc/libgcc.inc
+++ b/meta/recipes-devtools/gcc/libgcc.inc
@@ -15,17 +15,10 @@ LICENSE_${PN}-dev = "GPL-3.0-with-GCC-exception"
 LICENSE_${PN}-dbg = "GPL-3.0-with-GCC-exception"
 
 
-FILES_${PN} = "${base_libdir}/libgcc*.so.*"
 FILES_${PN}-dev = "\
     ${base_libdir}/libgcc*.so \
-    ${libdir}/${TARGET_SYS}/${BINV}/*crt* \
-    ${libdir}/${TARGET_SYS}/${BINV}/64 \
-    ${libdir}/${TARGET_SYS}/${BINV}/32 \
-    ${libdir}/${TARGET_SYS}/${BINV}/x32 \
-    ${libdir}/${TARGET_SYS}/${BINV}/n32 \
-    ${libdir}/${TARGET_SYS}/${BINV}/libgcc* \
     ${@base_conditional('BASETARGET_SYS', '${TARGET_SYS}', '', '${libdir}/${BASETARGET_SYS}', d)} \
-    ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \
+    ${libdir}/${TARGET_SYS}/${BINV}* \
 "
 
 FILES_${PN}-dbg += "${base_libdir}/.debug/"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-21 23:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-14 16:22 [PATCH] libgcc.inc: package baremetal multilib libraries Juro Bystricky
2015-09-14 16:38 ` Khem Raj
2015-09-14 19:53   ` Phil Blundell
2015-09-15 16:23     ` Bystricky, Juro
2015-09-21 23:21     ` [PATCH v2 0/1] libgcc: package multiple libraries Juro Bystricky
2015-09-21 23:21       ` [PATCH v2] libgcc.inc: package baremetal multilib libraries Juro Bystricky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox