Re: [PATCH] selftest/buildoptions: pexpect not a builtin module

[Benjamin Esquivel <benjamin.esquivel@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

On Fri, 2015-09-18 at 12:05 +0100, Burton, Ross wrote:
> 
> On 17 September 2015 at 21:38, Benjamin Esquivel <
> benjamin.esquivel@linux.intel.com> wrote:
> > put the import of pexpect around a try statement so it can tell you
> > why it failed to import when in a system that has the module
> > unreachable
> > 
> As the failing import is throwing an exception, can't the calling
> code display the exception correctly?
This is the logging without the change:
2015-09-18 08:27:44,233 - selftest - INFO - Loading tests from:
oeqa.selftest.buildhistory
2015-09-18 08:27:44,234 - selftest - INFO - Loading tests from:
oeqa.selftest.buildoptions
2015-09-18 08:27:44,236 - selftest - ERROR - Failed to import
oeqa.selftest.buildoptions
2015-09-18 08:27:44,236 - selftest - ERROR - 'module' object has no
attribute 'buildoptions'
This is the logging with the proposed change and including Paul's
comment:
2015-09-18 08:27:44,233 - selftest - INFO - Loading tests from:
oeqa.selftest.buildhistory
2015-09-18 08:27:44,234 - selftest - INFO - Loading tests from:
oeqa.selftest.buildoptions
No module named pexpect, import failed
Please install pexpect (python-pexpect)
2015-09-18 08:27:44,236 - selftest - ERROR - Failed to import
oeqa.selftest.buildoptions
2015-09-18 08:27:44,236 - selftest - ERROR - 'module' object has no
attribute 'buildoptions'
I'm sending the patch V2
> > Ross
> 

[-- Attachment #2: Type: text/html, Size: 2010 bytes --]