Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
To: "Istrate,
	Daniel AlexandruX" <daniel.alexandrux.istrate@intel.com>,
	 "Burton, Ross" <ross.burton@intel.com>
Cc: "paul.eggleton@linux.intel.com" <paul.eggleton@linux.intel.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH V2] selftest/buildoptions: pexpect not a builtin module
Date: Mon, 21 Sep 2015 11:27:20 -0500	[thread overview]
Message-ID: <1442852840.3222.1.camel@linux.intel.com> (raw)
In-Reply-To: <174AD7CFE5F468498ACCFE3FEE0EF1EB142C2921@IRSMSX102.ger.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

Great! thanks Daniel.
On Mon, 2015-09-21 at 10:49 +0000, Istrate, Daniel AlexandruX wrote:
> Hi Ross,
>  
> I sent the patch: http://lists.openembedded.org/pipermail/openembedde
> d-core/2015-September/110738.html
>  
> --Daniel
>  
> From: Burton, Ross [mailto:ross.burton@intel.com] 
> Sent: Monday, September 21, 2015 13:20
> To: Istrate, Daniel AlexandruX
> Cc: Benjamin Esquivel; openembedded-core@lists.openembedded.org; 
> paul.eggleton@linux.intel.com
> Subject: Re: [OE-core] [PATCH V2] selftest/buildoptions: pexpect not
> a builtin module
>  
>  
> On 21 September 2015 at 09:37, Istrate, Daniel AlexandruX <
> daniel.alexandrux.istrate@intel.com> wrote:
> Just want to point out that 'pexpect' is an unused import in
> buildoptions.py. Unused imports are also unittest and logging.
> Instead of try-catch an import that is not used I think it's best to
> get rid of them.
>  
> Totally agreed.  Can you send a quick patch?
>  
> Ross 

[-- Attachment #2: Type: text/html, Size: 4391 bytes --]

  reply	other threads:[~2015-09-21 16:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 20:38 [PATCH] selftest/buildoptions: pexpect not a builtin module Benjamin Esquivel
2015-09-18 11:05 ` Burton, Ross
2015-09-18 11:37   ` Paul Eggleton
2015-09-18  8:34     ` [PATCH V2] " Benjamin Esquivel
2015-09-21  8:37       ` Istrate, Daniel AlexandruX
2015-09-21 10:19         ` Burton, Ross
2015-09-21 10:49           ` Istrate, Daniel AlexandruX
2015-09-21 16:27             ` Benjamin Esquivel [this message]
2015-09-18 16:31   ` [PATCH] " Benjamin Esquivel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442852840.3222.1.camel@linux.intel.com \
    --to=benjamin.esquivel@linux.intel.com \
    --cc=daniel.alexandrux.istrate@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox