* [PATCH V2 1/3] core-mage-minimal-initramfs: replace dependency
2015-09-18 21:09 [PATCH V2 0/3] Dynamic common utilities Alejandro Joya
@ 2015-09-18 21:09 ` Alejandro Joya
2015-09-18 21:09 ` [PATCH V2 2/3] initramfs-framework:add virtual reference Alejandro Joya
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Alejandro Joya @ 2015-09-18 21:09 UTC (permalink / raw)
To: openembedded-core
This recipe have a hardcoded dependency to busybox, in order to be able to have a flexible selection,
instead of the hardcoded dependency,now is point to virtual reference.
Signed-off-by: Alejandro Joya <alejandro.joya.cruz@intel.com>
---
meta/recipes-core/images/core-image-minimal-initramfs.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/images/core-image-minimal-initramfs.bb b/meta/recipes-core/images/core-image-minimal-initramfs.bb
index 1f0fa95..50eca53 100644
--- a/meta/recipes-core/images/core-image-minimal-initramfs.bb
+++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb
@@ -3,7 +3,7 @@ DESCRIPTION = "Small image capable of booting a device. The kernel includes \
the Minimal RAM-based Initial Root Filesystem (initramfs), which finds the \
first 'init' program more efficiently."
-PACKAGE_INSTALL = "initramfs-live-boot initramfs-live-install initramfs-live-install-efi busybox udev base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}"
+PACKAGE_INSTALL = "initramfs-live-boot initramfs-live-install initramfs-live-install-efi virtual/base-utils udev base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}"
# Do not pollute the initrd image with rootfs features
IMAGE_FEATURES = ""
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2 2/3] initramfs-framework:add virtual reference
2015-09-18 21:09 [PATCH V2 0/3] Dynamic common utilities Alejandro Joya
2015-09-18 21:09 ` [PATCH V2 1/3] core-mage-minimal-initramfs: replace dependency Alejandro Joya
@ 2015-09-18 21:09 ` Alejandro Joya
2015-09-18 21:09 ` [PATCH V2 3/3] packagegroup-core-boot:change to " Alejandro Joya
2015-09-18 22:31 ` [PATCH V2 0/3] Dynamic common utilities Richard Purdie
3 siblings, 0 replies; 6+ messages in thread
From: Alejandro Joya @ 2015-09-18 21:09 UTC (permalink / raw)
To: openembedded-core
This recipe have a hardcoded dependency to busybox, in order to be able to have a flexible selection,
instead of the hardcoded dependency,now is point to virtual reference base-utils.
Signed-off-by: Alejandro Joya <alejandro.joya.cruz@intel.com>
---
meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
index 6c37b9a..5a6e254 100644
--- a/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
+++ b/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
@@ -1,7 +1,7 @@
SUMMARY = "Modular initramfs system"
LICENSE = "MIT"
LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-RDEPENDS_${PN} += "busybox"
+RDEPENDS_${PN} += "virtual/base-utils"
PR = "r2"
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2 3/3] packagegroup-core-boot:change to virtual reference
2015-09-18 21:09 [PATCH V2 0/3] Dynamic common utilities Alejandro Joya
2015-09-18 21:09 ` [PATCH V2 1/3] core-mage-minimal-initramfs: replace dependency Alejandro Joya
2015-09-18 21:09 ` [PATCH V2 2/3] initramfs-framework:add virtual reference Alejandro Joya
@ 2015-09-18 21:09 ` Alejandro Joya
2015-09-18 22:31 ` [PATCH V2 0/3] Dynamic common utilities Richard Purdie
3 siblings, 0 replies; 6+ messages in thread
From: Alejandro Joya @ 2015-09-18 21:09 UTC (permalink / raw)
To: openembedded-core
This recipe have a hardcoded dependency to busybox, in order to be able to have a flexible selection,
instead of the hardcoded dependency,now is point to virtual reference base-utils.
Signed-off-by: Alejandro Joya <alejandro.joya.cruz@intel.com>
---
meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
index 09f5373..38f29ce 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
@@ -19,12 +19,12 @@ MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS ?= ""
# Distro can override the following VIRTUAL-RUNTIME providers:
VIRTUAL-RUNTIME_dev_manager ?= "udev"
-VIRTUAL-RUNTIME_login_manager ?= "busybox"
+VIRTUAL-RUNTIME_login_manager ?= "${VIRTUAL-RUNTIME_base-utils}"
VIRTUAL-RUNTIME_init_manager ?= "sysvinit"
VIRTUAL-RUNTIME_initscripts ?= "initscripts"
VIRTUAL-RUNTIME_keymaps ?= "keymaps"
-SYSVINIT_SCRIPTS = "${@bb.utils.contains('MACHINE_FEATURES', 'rtc', 'busybox-hwclock', '', d)} \
+SYSVINIT_SCRIPTS = "${@bb.utils.contains('MACHINE_FEATURES', 'rtc', '${VIRTUAL-RUNTIME_base-utils-hwclock}', '', d)} \
modutils-initscripts \
init-ifupdown \
${VIRTUAL-RUNTIME_initscripts} \
@@ -33,7 +33,7 @@ SYSVINIT_SCRIPTS = "${@bb.utils.contains('MACHINE_FEATURES', 'rtc', 'busybox-hwc
RDEPENDS_${PN} = "\
base-files \
base-passwd \
- busybox \
+ ${VIRTUAL-RUNTIME_base-utils} \
${@bb.utils.contains("DISTRO_FEATURES", "sysvinit", "${SYSVINIT_SCRIPTS}", "", d)} \
${@bb.utils.contains("MACHINE_FEATURES", "keyboard", "${VIRTUAL-RUNTIME_keymaps}", "", d)} \
netbase \
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2 0/3] Dynamic common utilities
2015-09-18 21:09 [PATCH V2 0/3] Dynamic common utilities Alejandro Joya
` (2 preceding siblings ...)
2015-09-18 21:09 ` [PATCH V2 3/3] packagegroup-core-boot:change to " Alejandro Joya
@ 2015-09-18 22:31 ` Richard Purdie
2015-09-18 22:43 ` Joya Cruz, Alejandro
3 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2015-09-18 22:31 UTC (permalink / raw)
To: Alejandro Joya; +Cc: openembedded-core
On Fri, 2015-09-18 at 16:09 -0500, Alejandro Joya wrote:
> It provide a virtual reference for the common utilities.
> it replace of the lock to busybox, it will be simple exchange between other
> common utilities like gnu core utils or toybox among others.
>
> In order to enable its required to fill at the distro conf or local.conf
>
> VIRTUAL-RUNTIME_login_manager ?= "busybox"
> PREFERRED_PROVIDER_virtual/base-utils?= "busybox"
> PREFERRED_RPROVIDER_virtual/base-utils?= "busybox"
> VIRTUAL-RUNTIME_base-utils?= "busybox"
> VIRTUAL-RUNTIME_base-utils-hwclock ?= "busybox-hwclock"
As I understand it, you don't actually define defaults anywhere. This
means OE would break "out the box" which isn't acceptable and that alone
means I can't merge this.
Secondly, the virtual/xxx namespace is *only* for DEPENDS/PROVIDES, not
RDEPENDS or PACKAGE_INSTALL. For runtime packages, you need to use
${VIRTUAL-RUNTIME_base-utils}.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2 0/3] Dynamic common utilities
2015-09-18 22:31 ` [PATCH V2 0/3] Dynamic common utilities Richard Purdie
@ 2015-09-18 22:43 ` Joya Cruz, Alejandro
0 siblings, 0 replies; 6+ messages in thread
From: Joya Cruz, Alejandro @ 2015-09-18 22:43 UTC (permalink / raw)
To: richard.purdie@linuxfoundation.org
Cc: openembedded-core@lists.openembedded.org
On vie, 2015-09-18 at 23:31 +0100, Richard Purdie wrote:
> On Fri, 2015-09-18 at 16:09 -0500, Alejandro Joya wrote:
> > It provide a virtual reference for the common utilities.
> > it replace of the lock to busybox, it will be simple exchange between other
> > common utilities like gnu core utils or toybox among others.
> >
> > In order to enable its required to fill at the distro conf or local.conf
> >
> > VIRTUAL-RUNTIME_login_manager ?= "busybox"
> > PREFERRED_PROVIDER_virtual/base-utils?= "busybox"
> > PREFERRED_RPROVIDER_virtual/base-utils?= "busybox"
> > VIRTUAL-RUNTIME_base-utils?= "busybox"
> > VIRTUAL-RUNTIME_base-utils-hwclock ?= "busybox-hwclock"
>
> As I understand it, you don't actually define defaults anywhere. This
> means OE would break "out the box" which isn't acceptable and that alone
> means I can't merge this.
you are totally right, one of my doubts still is, where is the most
suitable place to defined this as single point?
>
> Secondly, the virtual/xxx namespace is *only* for DEPENDS/PROVIDES, not
> RDEPENDS or PACKAGE_INSTALL. For runtime packages, you need to use
> ${VIRTUAL-RUNTIME_base-utils}.
>
thanks I appreciated the correction.
> Cheers,
>
> Richard
>
^ permalink raw reply [flat|nested] 6+ messages in thread