From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] patch.bbclass: Finally remove support for deprecated "pnum=".
Date: Thu, 13 Dec 2012 09:32:28 +0000 [thread overview]
Message-ID: <1444001.YHLHxItvIU@helios> (raw)
In-Reply-To: <alpine.DEB.2.02.1212122024470.1116@oneiric>
On Wednesday 12 December 2012 20:25:50 Robert P. J. Day wrote:
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> someone else is welcome to apply this if it seems appropriate.
>
> diff --git a/meta/classes/patch.bbclass b/meta/classes/patch.bbclass
> index ed12802..31f76f6 100644
> --- a/meta/classes/patch.bbclass
> +++ b/meta/classes/patch.bbclass
> @@ -33,9 +33,6 @@ def src_patches(d, all = False ):
> patchparm = {'patchname': patchname}
> if "striplevel" in parm:
> striplevel = parm["striplevel"]
> - elif "pnum" in parm:
> - #bb.msg.warn(None, "Deprecated usage of 'pnum' url parameter in
> '%s', please use 'striplevel'" % url) - striplevel =
> parm["pnum"]
> else:
> striplevel = '1'
> patchparm['striplevel'] = striplevel
I'm not sure I see a pressing need to remove this support, but I am puzzled as
to why the "deprecated" message is commented out - that should definitely be
fixed if nothing else.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-13 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 1:25 [PATCH] patch.bbclass: Finally remove support for deprecated "pnum=" Robert P. J. Day
2012-12-13 8:10 ` Tomas Frydrych
2012-12-13 9:32 ` Paul Eggleton [this message]
2012-12-13 12:05 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444001.YHLHxItvIU@helios \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox