Re: [PATCH] patch.bbclass: Finally remove support for deprecated "pnum=".

["Robert P. J. Day" <rpjday@crashcourse.ca>]

On Thu, 13 Dec 2012, Paul Eggleton wrote:

> On Wednesday 12 December 2012 20:25:50 Robert P. J. Day wrote:
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> >   someone else is welcome to apply this if it seems appropriate.
> >
> > diff --git a/meta/classes/patch.bbclass b/meta/classes/patch.bbclass
> > index ed12802..31f76f6 100644
> > --- a/meta/classes/patch.bbclass
> > +++ b/meta/classes/patch.bbclass
> > @@ -33,9 +33,6 @@ def src_patches(d, all = False ):
> >          patchparm = {'patchname': patchname}
> >          if "striplevel" in parm:
> >              striplevel = parm["striplevel"]
> > -        elif "pnum" in parm:
> > -            #bb.msg.warn(None, "Deprecated usage of 'pnum' url parameter in
> > '%s', please use 'striplevel'" % url) -            striplevel =
> > parm["pnum"]
> >          else:
> >              striplevel = '1'
> >          patchparm['striplevel'] = striplevel
>
> I'm not sure I see a pressing need to remove this support, but I am
> puzzled as to why the "deprecated" message is commented out - that
> should definitely be fixed if nothing else.

  i believe i'll leave this decision in the hands of someone higher up
the food chain.  i will only observe that, with the exception of that
parameter in a single recipe i'm about to send in a patch for, i'm not
aware of it anywhere else.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================