Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
Cc: paul.eggleton@linux.intel.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] populate SDK: prepare calling of bb.utils for exceptions
Date: Fri, 16 Oct 2015 11:01:28 +0100	[thread overview]
Message-ID: <1444989688.17974.1.camel@linuxfoundation.org> (raw)
In-Reply-To: <1444930021-4096-1-git-send-email-benjamin.esquivel@linux.intel.com>

On Thu, 2015-10-15 at 12:27 -0500, Benjamin Esquivel wrote:
> +            if (bb.utils.movefile(sourcefile, destdir) == None):
> +                raise Exception("moving {} to {} failed".format(
> +                                        sourcefile, destdir))

Its a minor issue, however rightly or wrongly, the vast majority of the
code base uses "xxx %s %s" % (var, var2) instead of .format(). Is there
a reason we should be using the latter as for consistency, the former
would seem to make things more standardised?

Cheers,

Richard





  parent reply	other threads:[~2015-10-16 10:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 17:27 [PATCH] populate SDK: prepare calling of bb.utils for exceptions Benjamin Esquivel
2015-10-16  2:15 ` Christopher Larson
2015-10-16 20:28   ` Benjamin Esquivel
2015-10-16 21:50   ` [PATCH V2] " Benjamin Esquivel
2015-10-19  5:27     ` Mike Looijmans
2015-10-19 15:28       ` [PATCH V3] " Benjamin Esquivel
2015-10-16  7:00 ` [PATCH] " Mike Looijmans
2015-10-16 20:27   ` Benjamin Esquivel
2015-10-16 10:01 ` Richard Purdie [this message]
2015-10-16 20:18   ` Benjamin Esquivel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444989688.17974.1.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=benjamin.esquivel@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox