public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: Andrew Shadura <andrew.shadura@collabora.co.uk>
Cc: OE Core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v3 1/3] dbus: merge .bb and .inc
Date: Wed, 02 Dec 2015 17:27:19 +0100	[thread overview]
Message-ID: <1449073639.10734.65.camel@intel.com> (raw)
In-Reply-To: <e36072a82de706f1485c054adf8cb2d38a01e899.1448029554.git.andrew.shadura@collabora.co.uk>

On Fri, 2015-11-20 at 15:27 +0100, Andrew Shadura wrote:
> The split is no longer necessary, and only makes it more complicated to
> do changes in external layers.

I'm not sure about the "more complicated to do changes in external
layers". Why is that?

Quite the opposite, I found it useful that the version independent build
rules (*) were in a .inc file and relied on including that .inc file in
a "dbus-cynara" recipe which builds a specific fork of the source code
[2].

But I understand that this is an unusual usage of OE-core. As I didn't
notice the change in time (it's in master now), I'll just copy the
previous content of dbus.inc.

(*) However, a recent change in dizzy and fido already broke that
separation when adding a patch for 1.8.2 to the .inc file instead of
dbus-1.8.2.bb.

[1] http://cgit.openembedded.org/openembedded-core/commit/?id=a8aa06b2405dec31a306fdf47bd1fdf740fde7bd
[2] https://github.com/01org/meta-intel-iot-security/blob/7026d6e8e1084def0ebf203799360b54b5ac2763/meta-security-framework/recipes-core/dbus/dbus-cynara_1.8.18.bb

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.





  parent reply	other threads:[~2015-12-02 16:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 14:27 [PATCH v3 1/3] dbus: merge .bb and .inc Andrew Shadura
2015-11-20 14:27 ` [PATCH v3 2/3] dbus: update the recipes to 1.10.2 Andrew Shadura
2015-11-24 15:17   ` Burton, Ross
2016-01-08 14:50   ` Patrick Ohly
2015-11-20 14:27 ` [PATCH v3 3/3] dbus: add apparmor support Andrew Shadura
2015-12-02 16:27 ` Patrick Ohly [this message]
2015-12-02 16:47   ` [PATCH v3 1/3] dbus: merge .bb and .inc Burton, Ross
2015-12-03  7:46     ` Patrick Ohly
2015-12-03  8:39       ` Burton, Ross
2015-12-03  9:56         ` Patrick Ohly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449073639.10734.65.camel@intel.com \
    --to=patrick.ohly@intel.com \
    --cc=andrew.shadura@collabora.co.uk \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox