Re: [PATCH] bootimg/image: Enhance bootimg to respect RM_OLD_IMAGE

[Ricardo Neri <ricardo.neri-calderon@linux.intel.com>]

On Sat, 2016-01-30 at 10:54 +0000, Richard Purdie wrote:
> On Fri, 2016-01-29 at 17:34 -0800, Ricardo Neri wrote:
> > [Resending from an email subscribed to the oe list...]
> > On Sun, 2016-01-17 at 11:16 +0000, Richard Purdie wrote:
> > > @@ -294,7 +286,10 @@ python do_bootimg() {
> > >          bb.build.exec_func('build_efi_cfg', d)
> > >      bb.build.exec_func('build_hddimg', d)
> > >      bb.build.exec_func('build_iso', d)
> > > +    bb.build.exec_func('create_symlinks', d)
> > When I try to use bootimg.bbclass I get the following warning:
> > 
> > WARNING: Function create_symlinks doesn't exist
> > 
> > This is because create_symlinks is defined in image.bbclass but
> > bootimg.bbclass does not inherit from it. Should it be the case? Or
> > the
> > definiton of create_symlinks should be moved to a separate file?
> 
> I guess the key question is whether anyone is using bootimg.bbclass
> without using image.bbclass, or whether that is even
> possible/practical?

Hmm. Probably only image-live.bbclass. But if I understand correctly,
that class gets inherited by image.bbclass if live is specified in the
IMAGE_FSTYPES. 
> 
> Was this an existing setup that broke?

For the Linux UEFI Validation project we have a custom luv-live-image
recipe[1] that inherits from bootimg.bbclass but not from image.bbclass.
We have not had the need thus far. Our ramdisk does inherit
image.bbclass via core-image.bbclass[2].

Perhaps our live image recipe can be reworked to inherit from
image-live? Our main customization is that we have two partitions in the
bootable media.

Thanks and BR,
Ricardo

[1].https://github.com/01org/luv-yocto/blob/master/meta-luv/recipes-core/images/luv-live-image.bb
[2].https://github.com/01org/luv-yocto/blob/master/meta-luv/recipes-core/images/core-image-efi-initramfs.bb
> 
> Cheers,
> 
> Richard