Re: [PATCH 1/6] systemd: move bash completion into separate package

[Tanu Kaskinen <tanuk@iki.fi>]

On Mon, 2016-02-08 at 11:09 +0100, Maciej Borzecki wrote:
> Add systemd-bash package that ships bash completion files
> 
> Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> ---
>  meta/recipes-core/systemd/systemd_228.bb | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_228.bb b/meta/recipes-core/systemd/systemd_228.bb
> index a110f0cdeaac7e46b5691a89aea237974e4114b3..8e3cb6047588b286df728ff28423e469d0b0745d 100644
> --- a/meta/recipes-core/systemd/systemd_228.bb
> +++ b/meta/recipes-core/systemd/systemd_228.bb
> @@ -238,7 +238,7 @@ python populate_packages_prepend (){
>  PACKAGES_DYNAMIC += "^lib(udev|systemd).*"
>  
>  PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze ${PN}-kernel-install \
> -             ${PN}-rpm-macros ${PN}-binfmt ${PN}-pam ${PN}-zsh ${PN}-xorg-xinitrc"
> +             ${PN}-rpm-macros ${PN}-binfmt ${PN}-pam ${PN}-bash ${PN}-zsh ${PN}-xorg-xinitrc"
>  
>  SYSTEMD_PACKAGES = "${PN}-binfmt"
>  SYSTEMD_SERVICE_${PN}-binfmt = "systemd-binfmt.service"
> @@ -271,6 +271,11 @@ FILES_${PN}-rpm-macros = "${exec_prefix}/lib/rpm \
>  
>  FILES_${PN}-xorg-xinitrc = "${sysconfdir}/X11/xinit/xinitrc.d/*"
>  
> +FILES_${PN}-bash = " \
> +                    ${datadir}/bash-completion \
> +                    ${sysconfdir}/bash_completion.d/ \
> +                    "

Note that we have the bash-completion class. It can be used to take
care of packaging the bash completion files. It doesn't take files from
sysconfdir, though. Does systemd really install bash completion files
under sysconfdir, or is that just unnecessary cruft originating from
older systemd versions?

-- 
Tanu