Re: [PATCH 6/6] systemd: remove unnecessary code

[Randy MacLeod <randy.macleod@windriver.com>]

On 2016-02-08 05:09 AM, Maciej Borzecki wrote:
> Remove unnecessary chown on journal file.

I assume that it's unnecessary because the ownership bits
are fine. Could you state whether the default ownership
is root:systemd-journal or that's it's not root:systemd-journal
but it doesn't matter for some reason.

>
> Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> ---
>   meta/recipes-core/systemd/systemd_228.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/systemd/systemd_228.bb b/meta/recipes-core/systemd/systemd_228.bb
> index 40ed81a37e78c67bae13f7ee7018d85efa2f6b7d..03434ff9d5ff19fe043332b0b53a4fa96ab2b120 100644
> --- a/meta/recipes-core/systemd/systemd_228.bb
> +++ b/meta/recipes-core/systemd/systemd_228.bb
> @@ -209,7 +209,7 @@ do_install() {
>   		sed -i s%@UDEVD@%${rootlibexecdir}/systemd/systemd-udevd% ${D}${sysconfdir}/init.d/systemd-udevd
>   	fi
>
> -	chown root:systemd-journal ${D}/${localstatedir}/log/journal
> +        # chown root:systemd-journal ${D}/${localstatedir}/log/journal

If it's not needed, remove it rather than comment it out.

>
>           # Delete journal README, as log can be symlinked inside volatile.
>           rm -f ${D}/${localstatedir}/log/README
>


Thanks for this and the other commits to allow us to trim down the
systemd footprint. Reducing the image size by a few MB does matter
to some people!

-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5