[PATCH][jethro] glibc-locale: fix QA warning

[PATCH][jethro] glibc-locale: fix QA warning

[Armin Kuster]

From: Armin Kuster <akuster@mvista.com>

WARNING: QA Issue: glibc-locale: /glibc-binary-localedata-sd-in/usr/lib/locale/sd_IN/LC_CTYPE is owned by uid 1000, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]

fix type
Signed-off-by: Armin Kuster <akuster@mvista.com>
---
 meta/recipes-core/glibc/glibc-locale.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/glibc/glibc-locale.inc b/meta/recipes-core/glibc/glibc-locale.inc
index df6d073..2352bd0 100644
--- a/meta/recipes-core/glibc/glibc-locale.inc
+++ b/meta/recipes-core/glibc/glibc-locale.inc
@@ -87,7 +87,7 @@ do_install () {
 	if [ -e ${LOCALETREESRC}/${datadir}/locale ]; then
 		cp -fpPR ${LOCALETREESRC}/${datadir}/locale ${D}${datadir}
 	fi
-	chown root.root -R ${D}
+	chown root:root -R ${D}
 	cp -fpPR ${LOCALETREESRC}/SUPPORTED ${WORKDIR}
 }
 
-- 
2.3.5

Stable branch rules [Was: Re: [PATCH][jethro] glibc-locale: fix QA warning]

[Richard Purdie]

On Sun, 2016-01-31 at 11:55 -0800, Armin Kuster wrote:
> From: Armin Kuster <akuster@mvista.com>
> 
> WARNING: QA Issue: glibc-locale: /glibc-binary-localedata-sd
> -in/usr/lib/locale/sd_IN/LC_CTYPE is owned by uid 1000, which is the
> same as the user running bitbake. This may be due to host
> contamination [host-user-contaminated]
> 
> fix type
> Signed-off-by: Armin Kuster <akuster@mvista.com>
> ---
>  meta/recipes-core/glibc/glibc-locale.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Enough is enough.

I cannot tell whether these patches are in master or not or whether
master needs them or not. Master needs this one, its not in master, its
only being proposed for jethro. Its a mess.

I am therefore not taking any more stable branch patches at all until
we amend the stable branch rules to state that pull requests and
patches clearly state which branches need a fix, or clearly state why
they don't.

Cheers,

Richard

Re: [Openembedded-architecture] Stable branch rules [Was: Re: [PATCH][jethro] glibc-locale: fix QA warning]

[Khem Raj]

On Sun, Feb 7, 2016 at 2:43 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sun, 2016-01-31 at 11:55 -0800, Armin Kuster wrote:
>> From: Armin Kuster <akuster@mvista.com>
>>
>> WARNING: QA Issue: glibc-locale: /glibc-binary-localedata-sd
>> -in/usr/lib/locale/sd_IN/LC_CTYPE is owned by uid 1000, which is the
>> same as the user running bitbake. This may be due to host
>> contamination [host-user-contaminated]
>>
>> fix type
>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>> ---
>>  meta/recipes-core/glibc/glibc-locale.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Enough is enough.
>
> I cannot tell whether these patches are in master or not or whether
> master needs them or not. Master needs this one, its not in master, its
> only being proposed for jethro. Its a mess.


We should always check fix into master or ensure that master does not
exhibit same problem
If master needs fix then it should flow into stable branches via master.
In cases where master does not show the problem or has the isssue
fixed due to some other indirect
change which is too intrusive for stable branches, a patch for stable
only should be proposed.

In some cases we may offer to defer, master fixes if we are certain
that another pending chnages e.g. recipe upgrades can fix it
for master, I would still recommend that we propose it for master
still and recipe upgrade accounts for it later by removing this
change. At least we will have a cherry-pick chance to newer stable branches.

>
> I am therefore not taking any more stable branch patches at all until
> we amend the stable branch rules to state that pull requests and
> patches clearly state which branches need a fix, or clearly state why
> they don't.
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-architecture mailing list
> Openembedded-architecture@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-architecture

Re: Stable branch rules [Was: Re: [PATCH][jethro] glibc-locale: fix QA warning]

[Joshua G Lock]

On Sun, 2016-02-07 at 22:43 +0000, Richard Purdie wrote:
> On Sun, 2016-01-31 at 11:55 -0800, Armin Kuster wrote:
> > From: Armin Kuster <akuster@mvista.com>
> > 
> > WARNING: QA Issue: glibc-locale: /glibc-binary-localedata-sd
> > -in/usr/lib/locale/sd_IN/LC_CTYPE is owned by uid 1000, which is
> > the
> > same as the user running bitbake. This may be due to host
> > contamination [host-user-contaminated]
> > 
> > fix type
> > Signed-off-by: Armin Kuster <akuster@mvista.com>
> > ---
> >  meta/recipes-core/glibc/glibc-locale.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Enough is enough.
> 
> I cannot tell whether these patches are in master or not or whether
> master needs them or not. Master needs this one, its not in master,
> its
> only being proposed for jethro. Its a mess.
> 
> I am therefore not taking any more stable branch patches at all until
> we amend the stable branch rules to state that pull requests and
> patches clearly state which branches need a fix, or clearly state why
> they don't.

I made an attempt at starting to documenting that requirement:
https://wiki.yoctoproject.org/wiki/index.php?title=Stable_branch_mainte
nance&diff=17480&oldid=17028

'Patches' welcome.

Regards,

Joshua

Re: Stable branch rules [Was: Re: [PATCH][jethro] glibc-locale: fix QA warning]

[Philip Balister]

On 02/08/2016 10:22 AM, Joshua G Lock wrote:
> On Sun, 2016-02-07 at 22:43 +0000, Richard Purdie wrote:
>> On Sun, 2016-01-31 at 11:55 -0800, Armin Kuster wrote:
>>> From: Armin Kuster <akuster@mvista.com>
>>>
>>> WARNING: QA Issue: glibc-locale: /glibc-binary-localedata-sd
>>> -in/usr/lib/locale/sd_IN/LC_CTYPE is owned by uid 1000, which is
>>> the
>>> same as the user running bitbake. This may be due to host
>>> contamination [host-user-contaminated]
>>>
>>> fix type
>>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>>> ---
>>>  meta/recipes-core/glibc/glibc-locale.inc | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Enough is enough.
>>
>> I cannot tell whether these patches are in master or not or whether
>> master needs them or not. Master needs this one, its not in master,
>> its
>> only being proposed for jethro. Its a mess.
>>
>> I am therefore not taking any more stable branch patches at all until
>> we amend the stable branch rules to state that pull requests and
>> patches clearly state which branches need a fix, or clearly state why
>> they don't.
> 
> I made an attempt at starting to documenting that requirement:
> https://wiki.yoctoproject.org/wiki/index.php?title=Stable_branch_mainte
> nance&diff=17480&oldid=17028
> 
> 'Patches' welcome.

Does this belong on the Yocto Project or OpenEmbedded wikis? Hunting
both is getting annoying.

Philip

> 
> Regards,
> 
> Joshua
> 

Re: Stable branch rules [Was: Re: [PATCH][jethro] glibc-locale: fix QA warning]

[Joshua G Lock]

On Tue, 2016-02-09 at 09:50 -0500, Philip Balister wrote:
> On 02/08/2016 10:22 AM, Joshua G Lock wrote:
> > On Sun, 2016-02-07 at 22:43 +0000, Richard Purdie wrote:
> > > On Sun, 2016-01-31 at 11:55 -0800, Armin Kuster wrote:
> > > > From: Armin Kuster <akuster@mvista.com>
> > > > 
> > > > WARNING: QA Issue: glibc-locale: /glibc-binary-localedata-sd
> > > > -in/usr/lib/locale/sd_IN/LC_CTYPE is owned by uid 1000, which
> > > > is
> > > > the
> > > > same as the user running bitbake. This may be due to host
> > > > contamination [host-user-contaminated]
> > > > 
> > > > fix type
> > > > Signed-off-by: Armin Kuster <akuster@mvista.com>
> > > > ---
> > > >  meta/recipes-core/glibc/glibc-locale.inc | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > Enough is enough.
> > > 
> > > I cannot tell whether these patches are in master or not or
> > > whether
> > > master needs them or not. Master needs this one, its not in
> > > master,
> > > its
> > > only being proposed for jethro. Its a mess.
> > > 
> > > I am therefore not taking any more stable branch patches at all
> > > until
> > > we amend the stable branch rules to state that pull requests and
> > > patches clearly state which branches need a fix, or clearly state
> > > why
> > > they don't.
> > 
> > I made an attempt at starting to documenting that requirement:
> > https://wiki.yoctoproject.org/wiki/index.php?title=Stable_branch_ma
> > inte
> > nance&diff=17480&oldid=17028
> > 
> > 'Patches' welcome.
> 
> Does this belong on the Yocto Project or OpenEmbedded wikis? Hunting
> both is getting annoying.

I edited the guidelines where they currently exist. I'll be more than
happy to move this to the OE wiki, but I'd rather do that once we have
something that people can agree.

Regards,

Joshua

Re: [PATCH][jethro] glibc-locale: fix QA warning

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2124 bytes --]

On Sun, Jan 31, 2016 at 11:55:30AM -0800, Armin Kuster wrote:
> From: Armin Kuster <akuster@mvista.com>
> 
> WARNING: QA Issue: glibc-locale: /glibc-binary-localedata-sd-in/usr/lib/locale/sd_IN/LC_CTYPE is owned by uid 1000, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]

FWIW: my last bitbke world build shows few of these:
glibc-locale-2.23: glibc-locale: /glibc-binary-localedata-ka-ge/usr/lib/locale/ka_GE/LC_MEASUREMENT is owned by uid 3004, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
glibc-locale-2.23: glibc-locale: /glibc-binary-localedata-mr-in/usr/lib/locale/mr_IN/LC_MEASUREMENT is owned by uid 3004, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
glibc-locale-2.23: glibc-locale: /glibc-binary-localedata-ru-ua/usr/lib/locale/ru_UA/LC_MEASUREMENT is owned by uid 3004, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]

Even with your change already in master.

> fix type
> Signed-off-by: Armin Kuster <akuster@mvista.com>
> ---
>  meta/recipes-core/glibc/glibc-locale.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/glibc/glibc-locale.inc b/meta/recipes-core/glibc/glibc-locale.inc
> index df6d073..2352bd0 100644
> --- a/meta/recipes-core/glibc/glibc-locale.inc
> +++ b/meta/recipes-core/glibc/glibc-locale.inc
> @@ -87,7 +87,7 @@ do_install () {
>  	if [ -e ${LOCALETREESRC}/${datadir}/locale ]; then
>  		cp -fpPR ${LOCALETREESRC}/${datadir}/locale ${D}${datadir}
>  	fi
> -	chown root.root -R ${D}
> +	chown root:root -R ${D}
>  	cp -fpPR ${LOCALETREESRC}/SUPPORTED ${WORKDIR}
>  }
>  
> -- 
> 2.3.5
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH][jethro] glibc-locale: fix QA warning

[Richard Purdie]

On Fri, 2016-04-01 at 14:03 +0200, Martin Jansa wrote:
> On Sun, Jan 31, 2016 at 11:55:30AM -0800, Armin Kuster wrote:
> > From: Armin Kuster <akuster@mvista.com>
> > 
> > WARNING: QA Issue: glibc-locale: /glibc-binary-localedata-sd
> > -in/usr/lib/locale/sd_IN/LC_CTYPE is owned by uid 1000, which is
> > the same as the user running bitbake. This may be due to host
> > contamination [host-user-contaminated]
> 
> FWIW: my last bitbke world build shows few of these:
> glibc-locale-2.23: glibc-locale: /glibc-binary-localedata-ka
> -ge/usr/lib/locale/ka_GE/LC_MEASUREMENT is owned by uid 3004, which
> is the same as the user running bitbake. This may be due to host
> contamination [host-user-contaminated]
> glibc-locale-2.23: glibc-locale: /glibc-binary-localedata-mr
> -in/usr/lib/locale/mr_IN/LC_MEASUREMENT is owned by uid 3004, which
> is the same as the user running bitbake. This may be due to host
> contamination [host-user-contaminated]
> glibc-locale-2.23: glibc-locale: /glibc-binary-localedata-ru
> -ua/usr/lib/locale/ru_UA/LC_MEASUREMENT is owned by uid 3004, which
> is the same as the user running bitbake. This may be due to host
> contamination [host-user-contaminated]
> 
> Even with your change already in master.

I do wonder if this might be a pseudo issue which we fixed in master.
The trouble is that whilst master is working better, there is a bigger
rewrite/fixup of some pseudo code planned for 2.2 so even with master,
its not "properly" fixed yet. Master would error more clearly and
hasn't shown errors in recent builds though.

Cheers,

Richard

Re: [PATCH][jethro] glibc-locale: fix QA warning

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2485 bytes --]

On Fri, Apr 01, 2016 at 10:01:54AM -0700, akuster wrote:
> 
> 
> On 04/01/2016 05:03 AM, Martin Jansa wrote:
> > On Sun, Jan 31, 2016 at 11:55:30AM -0800, Armin Kuster wrote:
> >> From: Armin Kuster <akuster@mvista.com>
> >>
> >> WARNING: QA Issue: glibc-locale: /glibc-binary-localedata-sd-in/usr/lib/locale/sd_IN/LC_CTYPE is owned by uid 1000, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
> > 
> > FWIW: my last bitbke world build shows few of these:
> > glibc-locale-2.23: glibc-locale: /glibc-binary-localedata-ka-ge/usr/lib/locale/ka_GE/LC_MEASUREMENT is owned by uid 3004, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
> > glibc-locale-2.23: glibc-locale: /glibc-binary-localedata-mr-in/usr/lib/locale/mr_IN/LC_MEASUREMENT is owned by uid 3004, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
> > glibc-locale-2.23: glibc-locale: /glibc-binary-localedata-ru-ua/usr/lib/locale/ru_UA/LC_MEASUREMENT is owned by uid 3004, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
> > 
> 
> hmm. I have not seen those.
> 
> > Even with your change already in master.
> > 
> 
> so are you seeing those in master or jethro ?

master

> - armin
> 
> >> fix type
> >> Signed-off-by: Armin Kuster <akuster@mvista.com>
> >> ---
> >>  meta/recipes-core/glibc/glibc-locale.inc | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-core/glibc/glibc-locale.inc b/meta/recipes-core/glibc/glibc-locale.inc
> >> index df6d073..2352bd0 100644
> >> --- a/meta/recipes-core/glibc/glibc-locale.inc
> >> +++ b/meta/recipes-core/glibc/glibc-locale.inc
> >> @@ -87,7 +87,7 @@ do_install () {
> >>  	if [ -e ${LOCALETREESRC}/${datadir}/locale ]; then
> >>  		cp -fpPR ${LOCALETREESRC}/${datadir}/locale ${D}${datadir}
> >>  	fi
> >> -	chown root.root -R ${D}
> >> +	chown root:root -R ${D}
> >>  	cp -fpPR ${LOCALETREESRC}/SUPPORTED ${WORKDIR}
> >>  }
> >>  
> >> -- 
> >> 2.3.5
> >>
> >> -- 
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]