Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Christopher Larson <clarson@kergoth.com>,
	openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] ed_0.5: Handle --disable-static option
Date: Mon, 15 Feb 2016 16:58:01 +0000	[thread overview]
Message-ID: <1455555481.16142.424.camel@linuxfoundation.org> (raw)
In-Reply-To: <CABcZANmkyA_RYbjtHRirU1iByBJ44srcdLR360Neke+vGAjukA@mail.gmail.com>

On Mon, 2016-02-15 at 16:47 +0000, Christopher Larson wrote:
> 
> 
> On Mon, Feb 15, 2016 at 8:45 AM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > Also clean up use of immediate expansion as there are cleaner
> > mechanisms now.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > 
> > diff --git a/meta/recipes-extended/ed/ed_0.5.bb b/meta/recipes
> > -extended/ed/ed_0.5.bb
> > index 143e636..e2df13f 100644
> > --- a/meta/recipes-extended/ed/ed_0.5.bb
> > +++ b/meta/recipes-extended/ed/ed_0.5.bb
> > @@ -15,7 +15,6 @@ inherit autotools texinfo
> > 
> >  EXTRA_OECONF = "'CC=${CC}' 'CXX=${CXX}' 'CFLAGS=${CFLAGS}'
> > 'CXXFLAGS=${CXXFLAGS}' 'CPPFLAGS=${CPPFLAGS}' 'LDFLAGS=${LDFLAGS}'"
> > 
> > -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('-
> > -disable-dependency-tracking', ' ')}"
> > -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('-
> > -disable-silent-rules', ' ')}"
> > -
> > -
> > +CONFIGUREOPTS_remove = "--disable-dependency-tracking"
> > +CONFIGUREOPTS_remove = "--disable-silent-rules"
> > +EXTRA_OECONF_remove = "--disable-static"
> This will be impossible to undo in a bbappend.. 

I appreciate that and we've talked about ways we likely need to extend
the API for that.

In this case, I would ask why would anyone want/need to add in a
configure option which configure doesn't support?

I guess someone could patch it, however if they do that, the could also
pick a different option name.

Cheers,

Richard




  reply	other threads:[~2016-02-15 16:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 15:45 [PATCH] ed_0.5: Handle --disable-static option Richard Purdie
2016-02-15 16:47 ` Christopher Larson
2016-02-15 16:58   ` Richard Purdie [this message]
2016-02-15 17:04     ` Christopher Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455555481.16142.424.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=clarson@kergoth.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox