[PATCH] ed_0.5: Handle --disable-static option

[PATCH] ed_0.5: Handle --disable-static option

[Richard Purdie]

Also clean up use of immediate expansion as there are cleaner mechanisms now.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/recipes-extended/ed/ed_0.5.bb b/meta/recipes-extended/ed/ed_0.5.bb
index 143e636..e2df13f 100644
--- a/meta/recipes-extended/ed/ed_0.5.bb
+++ b/meta/recipes-extended/ed/ed_0.5.bb
@@ -15,7 +15,6 @@ inherit autotools texinfo
 
 EXTRA_OECONF = "'CC=${CC}' 'CXX=${CXX}' 'CFLAGS=${CFLAGS}' 'CXXFLAGS=${CXXFLAGS}' 'CPPFLAGS=${CPPFLAGS}' 'LDFLAGS=${LDFLAGS}'"
 
-CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('--disable-dependency-tracking', ' ')}"
-CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('--disable-silent-rules', ' ')}"
-
-
+CONFIGUREOPTS_remove = "--disable-dependency-tracking"
+CONFIGUREOPTS_remove = "--disable-silent-rules"
+EXTRA_OECONF_remove = "--disable-static"

Re: [PATCH] ed_0.5: Handle --disable-static option

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On Mon, Feb 15, 2016 at 8:45 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> Also clean up use of immediate expansion as there are cleaner mechanisms
> now.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> diff --git a/meta/recipes-extended/ed/ed_0.5.bb
> b/meta/recipes-extended/ed/ed_0.5.bb
> index 143e636..e2df13f 100644
> --- a/meta/recipes-extended/ed/ed_0.5.bb
> +++ b/meta/recipes-extended/ed/ed_0.5.bb
> @@ -15,7 +15,6 @@ inherit autotools texinfo
>
>  EXTRA_OECONF = "'CC=${CC}' 'CXX=${CXX}' 'CFLAGS=${CFLAGS}'
> 'CXXFLAGS=${CXXFLAGS}' 'CPPFLAGS=${CPPFLAGS}' 'LDFLAGS=${LDFLAGS}'"
>
> -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS',
> True).replace('--disable-dependency-tracking', ' ')}"
> -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS',
> True).replace('--disable-silent-rules', ' ')}"
> -
> -
> +CONFIGUREOPTS_remove = "--disable-dependency-tracking"
> +CONFIGUREOPTS_remove = "--disable-silent-rules"
> +EXTRA_OECONF_remove = "--disable-static"
>

This will be impossible to undo in a bbappend..

[-- Attachment #2: Type: text/html, Size: 1879 bytes --]

Re: [PATCH] ed_0.5: Handle --disable-static option

[Richard Purdie]

On Mon, 2016-02-15 at 16:47 +0000, Christopher Larson wrote:
> 
> 
> On Mon, Feb 15, 2016 at 8:45 AM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > Also clean up use of immediate expansion as there are cleaner
> > mechanisms now.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > 
> > diff --git a/meta/recipes-extended/ed/ed_0.5.bb b/meta/recipes
> > -extended/ed/ed_0.5.bb
> > index 143e636..e2df13f 100644
> > --- a/meta/recipes-extended/ed/ed_0.5.bb
> > +++ b/meta/recipes-extended/ed/ed_0.5.bb
> > @@ -15,7 +15,6 @@ inherit autotools texinfo
> > 
> >  EXTRA_OECONF = "'CC=${CC}' 'CXX=${CXX}' 'CFLAGS=${CFLAGS}'
> > 'CXXFLAGS=${CXXFLAGS}' 'CPPFLAGS=${CPPFLAGS}' 'LDFLAGS=${LDFLAGS}'"
> > 
> > -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('-
> > -disable-dependency-tracking', ' ')}"
> > -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('-
> > -disable-silent-rules', ' ')}"
> > -
> > -
> > +CONFIGUREOPTS_remove = "--disable-dependency-tracking"
> > +CONFIGUREOPTS_remove = "--disable-silent-rules"
> > +EXTRA_OECONF_remove = "--disable-static"
> This will be impossible to undo in a bbappend.. 

I appreciate that and we've talked about ways we likely need to extend
the API for that.

In this case, I would ask why would anyone want/need to add in a
configure option which configure doesn't support?

I guess someone could patch it, however if they do that, the could also
pick a different option name.

Cheers,

Richard

Re: [PATCH] ed_0.5: Handle --disable-static option

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

On Mon, Feb 15, 2016 at 9:58 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Mon, 2016-02-15 at 16:47 +0000, Christopher Larson wrote:
> >
> >
> > On Mon, Feb 15, 2016 at 8:45 AM Richard Purdie <
> > richard.purdie@linuxfoundation.org> wrote:
> > > Also clean up use of immediate expansion as there are cleaner
> > > mechanisms now.
> > >
> > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > >
> > > diff --git a/meta/recipes-extended/ed/ed_0.5.bb b/meta/recipes
> > > -extended/ed/ed_0.5.bb
> > > index 143e636..e2df13f 100644
> > > --- a/meta/recipes-extended/ed/ed_0.5.bb
> > > +++ b/meta/recipes-extended/ed/ed_0.5.bb
> > > @@ -15,7 +15,6 @@ inherit autotools texinfo
> > >
> > >  EXTRA_OECONF = "'CC=${CC}' 'CXX=${CXX}' 'CFLAGS=${CFLAGS}'
> > > 'CXXFLAGS=${CXXFLAGS}' 'CPPFLAGS=${CPPFLAGS}' 'LDFLAGS=${LDFLAGS}'"
> > >
> > > -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('-
> > > -disable-dependency-tracking', ' ')}"
> > > -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('-
> > > -disable-silent-rules', ' ')}"
> > > -
> > > -
> > > +CONFIGUREOPTS_remove = "--disable-dependency-tracking"
> > > +CONFIGUREOPTS_remove = "--disable-silent-rules"
> > > +EXTRA_OECONF_remove = "--disable-static"
> > This will be impossible to undo in a bbappend..
>
> I appreciate that and we've talked about ways we likely need to extend
> the API for that.
>
> In this case, I would ask why would anyone want/need to add in a
> configure option which configure doesn't support?
>

Right, fair enough, I didn't read the patch carefully enough. Sorry for the
distraction.

[-- Attachment #2: Type: text/html, Size: 2766 bytes --]