[PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Otavio Salvador]

To allow the use of Framebuffer-only distributions we cannot force the
existence of X11. This fixes:

,----
| ERROR: Nothing PROVIDES 'virtual/libx11-native' (but
|     virtual:native:.../meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
|     DEPENDS on or otherwise requires it)
`----

Error catch by O.S. Systems' autobuilder.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

 meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
index 9c0ec54..775abb9 100644
--- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
+++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
@@ -46,7 +46,7 @@ PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'alsa', 'alsa', '', d
                    ${@bb.utils.contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'opengl', '', d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
-PACKAGECONFIG_class-native = "x11"
+PACKAGECONFIG_class-native = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
 PACKAGECONFIG_class-nativesdk = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
 
 PACKAGECONFIG[alsa] = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib"
-- 
2.7.3

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Otavio Salvador]

On Mon, Mar 14, 2016 at 3:46 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> To allow the use of Framebuffer-only distributions we cannot force the
> existence of X11. This fixes:
>
> ,----
> | ERROR: Nothing PROVIDES 'virtual/libx11-native' (but
> |     virtual:native:.../meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> |     DEPENDS on or otherwise requires it)
> `----
>
> Error catch by O.S. Systems' autobuilder.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Just for completeness, this is only need on Jethro.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

On 14 March 2016 at 19:12, Otavio Salvador <otavio.salvador@ossystems.com.br
> wrote:

> Just for completeness, this is only need on Jethro.
>

Wouldn't a better fix be to
backport 161bb3409edee21827cf594cc011fe88185f1496?

Ross

[-- Attachment #2: Type: text/html, Size: 718 bytes --]

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Otavio Salvador]

On Mon, Mar 14, 2016 at 5:33 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 14 March 2016 at 19:12, Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
>>
>> Just for completeness, this is only need on Jethro.
>
>
> Wouldn't a better fix be to backport
> 161bb3409edee21827cf594cc011fe88185f1496?

This makes nativesdk and native feature set to differ. I don't think
it is a good move.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

On 14 March 2016 at 20:38, Otavio Salvador <otavio.salvador@ossystems.com.br
> wrote:

> This makes nativesdk and native feature set to differ. I don't think
> it is a good move
>

It's exactly the right move - nativesdk and native are different.  You want
nativesdk to match target, but native is unrelated to the distro you've
built (to be honest I'd prefer it if the required distro features logic
didn't execute on native recipes).

Ross

[-- Attachment #2: Type: text/html, Size: 874 bytes --]

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Otavio Salvador]

On Mon, Mar 14, 2016 at 5:41 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 14 March 2016 at 20:38, Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
>>
>> This makes nativesdk and native feature set to differ. I don't think
>> it is a good move
>
> It's exactly the right move - nativesdk and native are different.  You want
> nativesdk to match target, but native is unrelated to the distro you've
> built (to be honest I'd prefer it if the required distro features logic
> didn't execute on native recipes).

Well, with this it is harder to know if what works on native will work
on nativesdk. I don't like this behavior.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

On 14 March 2016 at 20:43, Otavio Salvador <otavio.salvador@ossystems.com.br
> wrote:

> Well, with this it is harder to know if what works on native will work
> on nativesdk. I don't like this behavior.
>

Again, native and nativesdk *are* different.  Just because a native recipe
builds doesn't mean a nativesdk one will, and their intended uses are
entirely different.

Ross

[-- Attachment #2: Type: text/html, Size: 798 bytes --]

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Otavio Salvador]

On Mon, Mar 14, 2016 at 5:46 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 14 March 2016 at 20:43, Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
>>
>> Well, with this it is harder to know if what works on native will work
>> on nativesdk. I don't like this behavior.
>
> Again, native and nativesdk *are* different.  Just because a native recipe
> builds doesn't mean a nativesdk one will, and their intended uses are
> entirely different.

I know it however up to now we could know that native and nativesdk
might respect DISTRO_FEATURES and be in sync. Now this is not truth
anymore.

I can live with that but this is not optimal in my point of view.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

On 14 March 2016 at 20:55, Otavio Salvador <otavio.salvador@ossystems.com.br
> wrote:

> I know it however up to now we could know that native and nativesdk
> might respect DISTRO_FEATURES and be in sync. Now this is not truth
> anymore.
>

It's been like this in master since December and the world hasn't exploded
just yet :)

Ross

[-- Attachment #2: Type: text/html, Size: 774 bytes --]

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Otavio Salvador]

On Mon, Mar 14, 2016 at 6:02 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 14 March 2016 at 20:55, Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
>>
>> I know it however up to now we could know that native and nativesdk
>> might respect DISTRO_FEATURES and be in sync. Now this is not truth
>> anymore.
>
> It's been like this in master since December and the world hasn't exploded
> just yet :)

Just because nobody complained, up to now, does not make it right.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

On Mon, Mar 14, 2016 at 2:04 PM Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

> On Mon, Mar 14, 2016 at 6:02 PM, Burton, Ross <ross.burton@intel.com>
> wrote:
> >
> > On 14 March 2016 at 20:55, Otavio Salvador
> > <otavio.salvador@ossystems.com.br> wrote:
> >>
> >> I know it however up to now we could know that native and nativesdk
> >> might respect DISTRO_FEATURES and be in sync. Now this is not truth
> >> anymore.
> >
> > It's been like this in master since December and the world hasn't
> exploded
> > just yet :)
>
> Just because nobody complained, up to now, does not make it right.
>

Personally, I agree wholeheartedly with Ross on this, I don't want my
native recipes obeying DISTRO_FEATURES, the policy is entirely different.

[-- Attachment #2: Type: text/html, Size: 1264 bytes --]

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Otavio Salvador]

On Mon, Mar 14, 2016 at 6:21 PM, Christopher Larson <clarson@kergoth.com> wrote:
> On Mon, Mar 14, 2016 at 2:04 PM Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
>>
>> On Mon, Mar 14, 2016 at 6:02 PM, Burton, Ross <ross.burton@intel.com>
>> wrote:
>> >
>> > On 14 March 2016 at 20:55, Otavio Salvador
>> > <otavio.salvador@ossystems.com.br> wrote:
>> >>
>> >> I know it however up to now we could know that native and nativesdk
>> >> might respect DISTRO_FEATURES and be in sync. Now this is not truth
>> >> anymore.
>> >
>> > It's been like this in master since December and the world hasn't
>> > exploded
>> > just yet :)
>>
>> Just because nobody complained, up to now, does not make it right.
>
>
> Personally, I agree wholeheartedly with Ross on this, I don't want my native
> recipes obeying DISTRO_FEATURES, the policy is entirely different.

Do you mind to explain to me why?

I would like to try to see your view on this.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On 14 March 2016 at 21:23, Otavio Salvador <otavio.salvador@ossystems.com.br
> wrote:

> Do you mind to explain to me why?
>
> I would like to try to see your view on this.
>

libsdl is a good example to be honest.  Why does your choice of target
distro features decide what libraries the native sdl should use?
Respecting them means in this case that you can't have a graphical qemu.
Taking it to hypotheticals, just because my target is pure Wayland doesn't
mean I expect sdl to build for Wayland without X11, especially if my
desktop is X11 based.

Ross

[-- Attachment #2: Type: text/html, Size: 983 bytes --]

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Otavio Salvador]

On Mon, Mar 14, 2016 at 6:26 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 14 March 2016 at 21:23, Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
>>
>> Do you mind to explain to me why?
>>
>> I would like to try to see your view on this.
>
>
> libsdl is a good example to be honest.  Why does your choice of target
> distro features decide what libraries the native sdl should use?  Respecting
> them means in this case that you can't have a graphical qemu.  Taking it to
> hypotheticals, just because my target is pure Wayland doesn't mean I expect
> sdl to build for Wayland without X11, especially if my desktop is X11 based.

I agree with the overall goal here however this means we ought to have
a HOST_DISTRO_FEATURES setting and not ignore it at all.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] libsdl: Only enable X11 support when the DISTRO supports it

[Richard Purdie]

On Tue, 2016-03-15 at 08:01 -0300, Otavio Salvador wrote:
> On Mon, Mar 14, 2016 at 6:26 PM, Burton, Ross <ross.burton@intel.com>
> wrote:
> > 
> > On 14 March 2016 at 21:23, Otavio Salvador
> > <otavio.salvador@ossystems.com.br> wrote:
> > > 
> > > Do you mind to explain to me why?
> > > 
> > > I would like to try to see your view on this.
> > 
> > 
> > libsdl is a good example to be honest.  Why does your choice of
> > target
> > distro features decide what libraries the native sdl should use? 
> >  Respecting
> > them means in this case that you can't have a graphical qemu. 
> >  Taking it to
> > hypotheticals, just because my target is pure Wayland doesn't mean
> > I expect
> > sdl to build for Wayland without X11, especially if my desktop is
> > X11 based.
> 
> I agree with the overall goal here however this means we ought to
> have
> a HOST_DISTRO_FEATURES setting and not ignore it at all.

I think right now there isn't a pressing need for the extra
complications this brings in. Obviously we should watch the situation
carefully though.

Cheers,

Richard