[PATCH RESEND 1/4] ARM: handle missing thumb suffix

[PATCH RESEND 1/4] ARM: handle missing thumb suffix

[Jens Rehsack]

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

When enabling tune for arm926ejs, poky optionally appends suffixes for
thumb and dsp support. Since sometimes arm926ejse (ARM code) and sometime
arm926ejste (thumb code) is used in PACKAGE_ARCH, allow both.

Signed-off-by: Jens Rehsack <sno@netbsd.org>
---
 meta/conf/machine/include/tune-arm926ejs.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/machine/include/tune-arm926ejs.inc b/meta/conf/machine/include/tune-arm926ejs.inc
index 4f4d7dc..81bcda3 100644
--- a/meta/conf/machine/include/tune-arm926ejs.inc
+++ b/meta/conf/machine/include/tune-arm926ejs.inc
@@ -8,4 +8,4 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'arm926ejs', ' -mcpu=arm92
 AVAILTUNES += "arm926ejs"
 ARMPKGARCH_tune-arm926ejs = "arm926ejs"
 TUNE_FEATURES_tune-arm926ejs = "${TUNE_FEATURES_tune-armv5te} arm926ejs"
-PACKAGE_EXTRA_ARCHS_tune-arm926ejs = "${PACKAGE_EXTRA_ARCHS_tune-armv5te} arm926ejste"
+PACKAGE_EXTRA_ARCHS_tune-arm926ejs = "${PACKAGE_EXTRA_ARCHS_tune-armv5te} arm926ejste arm926ejse"
--
2.6.3

Please apply this one to OE-Core - it has been discussed completely (see http://patchwork.openembedded.org/patch/105231/).
@Otavio: Ross gave me the hint to ask you for ACK'ing - if possible (please don't, if it hurts).

Cheers
--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 859 bytes --]

Re: [PATCH RESEND 1/4] ARM: handle missing thumb suffix

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

On Wed, Mar 16, 2016 at 10:34:22AM +0100, Jens Rehsack wrote:
> When enabling tune for arm926ejs, poky optionally appends suffixes for

tune files, not poky appends them.

Other than that.

Acked-By: Martin Jansa <Martin.Jansa@gmail.com>

> thumb and dsp support. Since sometimes arm926ejse (ARM code) and sometime
> arm926ejste (thumb code) is used in PACKAGE_ARCH, allow both.
> 
> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> ---
>  meta/conf/machine/include/tune-arm926ejs.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/conf/machine/include/tune-arm926ejs.inc b/meta/conf/machine/include/tune-arm926ejs.inc
> index 4f4d7dc..81bcda3 100644
> --- a/meta/conf/machine/include/tune-arm926ejs.inc
> +++ b/meta/conf/machine/include/tune-arm926ejs.inc
> @@ -8,4 +8,4 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'arm926ejs', ' -mcpu=arm92
>  AVAILTUNES += "arm926ejs"
>  ARMPKGARCH_tune-arm926ejs = "arm926ejs"
>  TUNE_FEATURES_tune-arm926ejs = "${TUNE_FEATURES_tune-armv5te} arm926ejs"
> -PACKAGE_EXTRA_ARCHS_tune-arm926ejs = "${PACKAGE_EXTRA_ARCHS_tune-armv5te} arm926ejste"
> +PACKAGE_EXTRA_ARCHS_tune-arm926ejs = "${PACKAGE_EXTRA_ARCHS_tune-armv5te} arm926ejste arm926ejse"
> --
> 2.6.3
> 
> Please apply this one to OE-Core - it has been discussed completely (see http://patchwork.openembedded.org/patch/105231/).
> @Otavio: Ross gave me the hint to ask you for ACK'ing - if possible (please don't, if it hurts).
> 
> Cheers
> --
> Jens Rehsack - rehsack@gmail.com
> 



-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH RESEND 1/4] ARM: handle missing thumb suffix

[Phil Blundell]

On Wed, 2016-03-16 at 10:34 +0100, Jens Rehsack wrote:
> When enabling tune for arm926ejs, poky optionally appends suffixes for
> thumb and dsp support. Since sometimes arm926ejse (ARM code) and sometime
> arm926ejste (thumb code) is used in PACKAGE_ARCH, allow both.

Personally I think this is a further argument for fixing the tune files
to simply not append these suffixes rather than doubling up the allowed
architectures everywhere.  See previous discussion on the oe-core list.

Also, just on a matter of style, if you are submitting a patch to
oe-core then the description probably oughtn't to refer to things that
"Poky" does.

p.

Re: [PATCH RESEND 1/4] ARM: handle missing thumb suffix

[Jens Rehsack]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]


> Am 16.03.2016 um 13:20 schrieb Phil Blundell <pb@pbcl.net>:
> 
> On Wed, 2016-03-16 at 10:34 +0100, Jens Rehsack wrote:
>> When enabling tune for arm926ejs, poky optionally appends suffixes for
>> thumb and dsp support. Since sometimes arm926ejse (ARM code) and sometime
>> arm926ejste (thumb code) is used in PACKAGE_ARCH, allow both.
> 
> Personally I think this is a further argument for fixing the tune files
> to simply not append these suffixes rather than doubling up the allowed
> architectures everywhere.  See previous discussion on the oe-core list.

Yes, you're invited to send patches. Meanwhile - why does it bother you
a platform (kirkwood) doesn't has build errors anymore by applying that
patch?

> Also, just on a matter of style, if you are submitting a patch to
> oe-core then the description probably oughtn't to refer to things that
> "Poky" does.

Again: Please send me an updated commit message. I tried my best in
digging down where and what is appended to dozen of flags resulting
in proper or weird build behavior.

"All that smells" makes you look wise - but doesn't help in particular
projects :)

Cheers
--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 859 bytes --]

Re: [PATCH RESEND 1/4] ARM: handle missing thumb suffix

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

On 16 March 2016 at 13:18, Jens Rehsack <rehsack@gmail.com> wrote:

> Again: Please send me an updated commit message. I tried my best in
> digging down where and what is appended to dozen of flags resulting
> in proper or weird build behavior.
>

s/poky/oe-core/, and the subject prefix should be tune-arm926ejs instead of
ARM.

To be honest I'll apply those in my staging branch, don't bother re-sending.

Ross

[-- Attachment #2: Type: text/html, Size: 1142 bytes --]