[PATCH] package.bbclass: Treat .node files same as .so

[PATCH] package.bbclass: Treat .node files same as .so

[brendan.le.foll]

From: Brendan Le Foll <brendan.le.foll@intel.com>

Typically in a node/npm compiled modules the module is named .node. This is a
binary module without a wrapper so it can actually be relatively large if
unstripped.

Signed-off-by: Brendan Le Foll <brendan.le.foll@intel.com>
---
 meta/classes/package.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index ef80e50..cd9d5a6 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -907,7 +907,7 @@ python split_and_strip_files () {
                     continue
                 # Check its an excutable
                 if (s[stat.ST_MODE] & stat.S_IXUSR) or (s[stat.ST_MODE] & stat.S_IXGRP) or (s[stat.ST_MODE] & stat.S_IXOTH) \
-                        or ((file.startswith(libdir) or file.startswith(baselibdir)) and ".so" in f):
+                        or ((file.startswith(libdir) or file.startswith(baselibdir)) and (".so" or ".node" in f)):
                     # If it's a symlink, and points to an ELF file, we capture the readlink target
                     if cpath.islink(file):
                         target = os.readlink(file)
-- 
2.7.2

Re: [PATCH] package.bbclass: Treat .node files same as .so

[Richard Purdie]

On Mon, 2016-03-21 at 22:52 +0000, brendan.le.foll@intel.com wrote:
> (".so" or ".node" in f)

I'm not sure this will do what you expect with python's operator
ordering?

$ python
>>> bar=[1]
>>> 2 or 1 in bar
2
>>> 2 in bar or 1 in bar
True

Cheers,

Richard