From: Bill Randle <william.c.randle@intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] insane.bbclass: tighten lib_re and exec_re patterns to avoid false positive
Date: Wed, 23 Mar 2016 08:54:21 -0700 [thread overview]
Message-ID: <1458748461-4643-1-git-send-email-william.c.randle@intel.com> (raw)
lib_re would match files like "/libsoletta.so.0.0.1-gdb.py" which are
not valid library filenames. Tighten up the re for lib_re and exec_re
so they match only valid sonames (.so or .so followed by major version
and optional minor version and release).
[YOCTO #9215]
Signed-off-by: Bill Randle <william.c.randle@intel.com>
---
meta/classes/insane.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 7ac945d..e60c358 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -318,8 +318,8 @@ def package_qa_check_libdir(d):
messages = []
- lib_re = re.compile("^/lib.+\.so(\..+)?$")
- exec_re = re.compile("^%s.*/lib.+\.so(\..+)?$" % exec_prefix)
+ lib_re = re.compile("^/lib.+\.so(\.\d+){0,3}$")
+ exec_re = re.compile("^%s.*/lib.+\.so(\.\d+){0,3}$" % exec_prefix)
for root, dirs, files in os.walk(pkgdest):
if root == pkgdest:
--
2.5.0
next reply other threads:[~2016-03-23 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 15:54 Bill Randle [this message]
2016-03-23 16:23 ` [PATCH] insane.bbclass: tighten lib_re and exec_re patterns to avoid false positive Burton, Ross
2016-03-23 16:40 ` Randle, William C
2016-03-23 17:56 ` Phil Blundell
2016-03-23 17:59 ` Burton, Ross
2016-03-23 18:03 ` Phil Blundell
2016-03-23 21:17 ` Burton, Ross
2016-03-23 21:36 ` Randle, William C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458748461-4643-1-git-send-email-william.c.randle@intel.com \
--to=william.c.randle@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox