From: Phil Blundell <pb@pbcl.net>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] insane.bbclass: tighten lib_re and exec_re patterns to avoid false positive
Date: Wed, 23 Mar 2016 18:03:54 +0000 [thread overview]
Message-ID: <1458756234.3476.189.camel@pbcl.net> (raw)
In-Reply-To: <CAJTo0LbicCM6LJbxEK8m-QES49-WjPJsDUgduV0-dOg1FSEdZw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Wed, 2016-03-23 at 17:59 +0000, Burton, Ross wrote:
>
> On 23 March 2016 at 17:56, Phil Blundell <pb@pbcl.net> wrote:
> > > lib_re would match files like "/libsoletta.so.0.0.1-gdb.py" which
> > are
> > > not valid library filenames.
> >
> > What are the consequences of it matching things that are not
> > libraries?
> See #9215, the libdir sanity test fires when it shouldn't.
>
> WARNING: QA Issue: soletta-dbg: found library in wrong location:
> /usr/share/gdb/auto-load/libsoletta.so.0.0.1-gdb.py [libdir]
>
> That's no library...
Ah, right. I see.
I wonder if we should just give insane.bbclass a whitelist of
directories in which it should ignore apparently misplaced libraries.
There aren't likely to be many cases like that one.
Or alternatively, add an extra check so that when it thinks it's found
a misplaced library, it checks the ELF header to make sure that it
really is one and suppresses the diagnostic if not. If you only do
this in cases where it was about to print a warning anyway then the
impact on performance shouldn't be too bad.
p.
[-- Attachment #2: Type: text/html, Size: 1642 bytes --]
next prev parent reply other threads:[~2016-03-23 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 15:54 [PATCH] insane.bbclass: tighten lib_re and exec_re patterns to avoid false positive Bill Randle
2016-03-23 16:23 ` Burton, Ross
2016-03-23 16:40 ` Randle, William C
2016-03-23 17:56 ` Phil Blundell
2016-03-23 17:59 ` Burton, Ross
2016-03-23 18:03 ` Phil Blundell [this message]
2016-03-23 21:17 ` Burton, Ross
2016-03-23 21:36 ` Randle, William C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458756234.3476.189.camel@pbcl.net \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox