Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] gdb-cross-canadian: use PACKAGECONFIG for python and readline
@ 2016-03-25 11:33 Jonathan Liu
  2016-03-26 22:46 ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Liu @ 2016-03-25 11:33 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
index ae97759..6e42af1 100644
--- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
@@ -5,15 +5,17 @@ SUMMARY = "GNU debugger (cross-canadian gdb for ${TARGET_ARCH} target)"
 PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
 BPN = "gdb"
 
-DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext nativesdk-readline nativesdk-python \
+DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
            virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-${HOST_PREFIX}libc-for-gcc"
 
-RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-re \
-                   nativesdk-python-codecs nativesdk-python-netclient"
-
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
-EXTRA_OECONF_append = " --with-python=${WORKDIR}/python"
+# Overrides PACKAGECONFIG variables in gdb-common.inc
+PACKAGECONFIG ??= "python readline"
+PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,nativesdk-python, \
+                         nativesdk-python-core nativesdk-python-lang nativesdk-python-re \
+                         nativesdk-python-codecs nativesdk-python-netclient"
+PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,nativesdk-readline"
 
 SSTATE_DUPWHITELIST += "${STAGING_DATADIR}/gdb"
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdb-cross-canadian: use PACKAGECONFIG for python and readline
  2016-03-25 11:33 [PATCH] gdb-cross-canadian: use PACKAGECONFIG for python and readline Jonathan Liu
@ 2016-03-26 22:46 ` Richard Purdie
  2016-03-27  0:45   ` Jonathan Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2016-03-26 22:46 UTC (permalink / raw)
  To: Jonathan Liu, openembedded-core

On Fri, 2016-03-25 at 22:33 +1100, Jonathan Liu wrote:
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> index ae97759..6e42af1 100644
> --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> @@ -5,15 +5,17 @@ SUMMARY = "GNU debugger (cross-canadian gdb for
> ${TARGET_ARCH} target)"
>  PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
>  BPN = "gdb"
>  
> -DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext
> nativesdk-readline nativesdk-python \
> +DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
>             virtual/${HOST_PREFIX}gcc-crosssdk
> virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk
> -${HOST_PREFIX}libc-for-gcc"
>  
> -RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang
> nativesdk-python-re \
> -                   nativesdk-python-codecs nativesdk-python
> -netclient"
> -
>  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
>  
> -EXTRA_OECONF_append = " --with-python=${WORKDIR}/python"
> +# Overrides PACKAGECONFIG variables in gdb-common.inc
> +PACKAGECONFIG ??= "python readline"
> +PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without
> -python,nativesdk-python, \
> +                         nativesdk-python-core nativesdk-python-lang
> nativesdk-python-re \
> +                         nativesdk-python-codecs nativesdk-python
> -netclient"
> +PACKAGECONFIG[readline] = "--with-system-readline,--without-system
> -readline,nativesdk-readline"
>  
>  SSTATE_DUPWHITELIST += "${STAGING_DATADIR}/gdb"

Sadly this breaks multilib tests on the autobuilder:

https://autobuilder.yoctoproject.org/main/builders/nightly-multilib/bui
lds/719/steps/BuildImages/logs/stdio

I'll have to remove this from the queue until we can figure out a
fix...

Cheers,

Richard


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdb-cross-canadian: use PACKAGECONFIG for python and readline
  2016-03-26 22:46 ` Richard Purdie
@ 2016-03-27  0:45   ` Jonathan Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Liu @ 2016-03-27  0:45 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core@lists.openembedded.org

Hi Richard,

On 27 March 2016 at 09:46, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2016-03-25 at 22:33 +1100, Jonathan Liu wrote:
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>>  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 12 +++++++-----
>>  1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>> b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>> index ae97759..6e42af1 100644
>> --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>> +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>> @@ -5,15 +5,17 @@ SUMMARY = "GNU debugger (cross-canadian gdb for
>> ${TARGET_ARCH} target)"
>>  PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
>>  BPN = "gdb"
>>
>> -DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext
>> nativesdk-readline nativesdk-python \
>> +DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
>>             virtual/${HOST_PREFIX}gcc-crosssdk
>> virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk
>> -${HOST_PREFIX}libc-for-gcc"
>>
>> -RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang
>> nativesdk-python-re \
>> -                   nativesdk-python-codecs nativesdk-python
>> -netclient"
>> -
>>  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
>>
>> -EXTRA_OECONF_append = " --with-python=${WORKDIR}/python"
>> +# Overrides PACKAGECONFIG variables in gdb-common.inc
>> +PACKAGECONFIG ??= "python readline"
>> +PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without
>> -python,nativesdk-python, \
>> +                         nativesdk-python-core nativesdk-python-lang
>> nativesdk-python-re \
>> +                         nativesdk-python-codecs nativesdk-python
>> -netclient"
>> +PACKAGECONFIG[readline] = "--with-system-readline,--without-system
>> -readline,nativesdk-readline"
>>
>>  SSTATE_DUPWHITELIST += "${STAGING_DATADIR}/gdb"
>
> Sadly this breaks multilib tests on the autobuilder:
>
> https://autobuilder.yoctoproject.org/main/builders/nightly-multilib/bui
> lds/719/steps/BuildImages/logs/stdio
>
> I'll have to remove this from the queue until we can figure out a
> fix...
>
> Cheers,
>
> Richard

I have posted another patchset which takes a different approach and
disables the conflicting PACKAGECONFIG variables.

Regards,
Jonathan


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-27  0:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-25 11:33 [PATCH] gdb-cross-canadian: use PACKAGECONFIG for python and readline Jonathan Liu
2016-03-26 22:46 ` Richard Purdie
2016-03-27  0:45   ` Jonathan Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox