Re: [PATCH 1/1] coreutils: correct the case for class-native

[Joshua G Lock <joshua.g.lock@linux.intel.com>]

On Wed, 2016-04-06 at 12:50 +0800, Robert Yang wrote:
> 
> On 04/06/2016 12:45 PM, Dengke Du wrote:
> > 
> > The function of do_install_append_class-native for class-native
> > had alread exist,so exclude the class-native in function
> > do_install_append.
> > 
> > Signed-off-by: Dengke Du <dengke.du@windriver.com>
> > ---
> >   meta/recipes-core/coreutils/coreutils_8.25.bb | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/meta/recipes-core/coreutils/coreutils_8.25.bb
> > b/meta/recipes-core/coreutils/coreutils_8.25.bb
> > index 419a693..e8e269a 100644
> > --- a/meta/recipes-core/coreutils/coreutils_8.25.bb
> > +++ b/meta/recipes-core/coreutils/coreutils_8.25.bb
> > @@ -70,6 +70,10 @@ do_compile_prepend () {
> >   }
> > 
> >   do_install_append() {
> > +	if [ "${CLASSOVERRIDE}" = "class-native" ]; then
> > +		return
> > +	fi
> > +

If the do_install_append is only valid for the target it'd be cleaner
to use a target-specific override i.e.

do_install_append_class-target () {
}

Thanks,

Joshua