From: Robert Yang <liezhi.yang@windriver.com>
To: Joshua G Lock <joshua.g.lock@linux.intel.com>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] coreutils: correct the case for class-native
Date: Wed, 6 Apr 2016 16:53:24 +0800 [thread overview]
Message-ID: <5704CE84.6090204@windriver.com> (raw)
In-Reply-To: <1459932124.5713.1.camel@linux.intel.com>
On 04/06/2016 04:42 PM, Joshua G Lock wrote:
> On Wed, 2016-04-06 at 12:50 +0800, Robert Yang wrote:
>>
>> On 04/06/2016 12:45 PM, Dengke Du wrote:
>>>
>>> The function of do_install_append_class-native for class-native
>>> had alread exist,so exclude the class-native in function
>>> do_install_append.
>>>
>>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
>>> ---
>>> meta/recipes-core/coreutils/coreutils_8.25.bb | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> b/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> index 419a693..e8e269a 100644
>>> --- a/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> +++ b/meta/recipes-core/coreutils/coreutils_8.25.bb
>>> @@ -70,6 +70,10 @@ do_compile_prepend () {
>>> }
>>>
>>> do_install_append() {
>>> + if [ "${CLASSOVERRIDE}" = "class-native" ]; then
>>> + return
>>> + fi
>>> +
>
> If the do_install_append is only valid for the target it'd be cleaner
> to use a target-specific override i.e.
Thanks, but it is needed by both target and nativesdk.
// Robert
>
> do_install_append_class-target () {
> }
>
> Thanks,
>
> Joshua
>
next prev parent reply other threads:[~2016-04-06 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 4:44 [PATCH 0/1] coreutils: correct the case for class-native Dengke Du
2016-04-06 4:45 ` [PATCH 1/1] " Dengke Du
2016-04-06 4:49 ` dengke.du
2016-04-06 4:50 ` Robert Yang
2016-04-06 8:42 ` Joshua G Lock
2016-04-06 8:53 ` Robert Yang [this message]
2016-04-21 4:49 ` dengke.du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5704CE84.6090204@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=joshua.g.lock@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox