From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/6] insane.bbclass: package_qa_check_license -> do_qa_populate_lic
Date: Tue, 26 Apr 2016 09:56:03 +0100 [thread overview]
Message-ID: <1461660963.31320.147.camel@linuxfoundation.org> (raw)
In-Reply-To: <e1d663a4f78339b9df14168beec65fa0d3a1e45f.1461592183.git.liezhi.yang@windriver.com>
On Mon, 2016-04-25 at 06:51 -0700, Robert Yang wrote:
> The package_qa_check_license() was in do_qa_configure which had a
> potential problem, when the recipe sets do_configure[noexec] = "1",
> then
> the license checking won't run, which may hidden license issues.
> Rename
> it to do_qa_populate_lic() and run in do_populate_lic[postfuncs]
> which
> is more reasonable (when no populate license, no license checking).
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/classes/insane.bbclass | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
There is a convention that "do_" as a function prefix means its a task.
In this case its not a task but a function, so can you use a different
prefix please?
Cheers,
Richard
next prev parent reply other threads:[~2016-04-26 8:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 13:51 [PATCH 0/6] insane.bbclass: package_qa_check_license -> do_qa_populate_lic Robert Yang
2016-04-25 13:51 ` [PATCH 1/6] insane.bbclass: remove workdir from package_qa_check_license() Robert Yang
2016-04-25 13:51 ` [PATCH 2/6] insane.bbclass: package_qa_check_license -> do_qa_populate_lic Robert Yang
2016-04-26 8:56 ` Richard Purdie [this message]
2016-04-26 9:01 ` Robert Yang
2016-04-27 2:28 ` Robert Yang
2016-04-25 13:51 ` [PATCH 3/6] packagegroup.bbclass: set LICENSE and LIC_FILES_CHKSUM Robert Yang
2016-04-25 13:51 ` [PATCH 4/6] packagegroup-foo.bb: remove LICENSE = "MIT" Robert Yang
2016-04-25 13:51 ` [PATCH 5/6] meta-world-pkgdata: add LIC_FILES_CHKSUM Robert Yang
2016-04-25 13:51 ` [PATCH 6/6] libxsettings-client: fix LICENSE Robert Yang
2016-04-25 15:26 ` Burton, Ross
2016-04-26 0:44 ` Robert Yang
2016-04-26 13:29 ` Burton, Ross
2016-04-26 13:57 ` Flanagan, Elizabeth
2016-04-26 16:43 ` Khem Raj
2016-04-26 16:56 ` Burton, Ross
2016-04-27 1:18 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461660963.31320.147.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox