Re: [PATCH 2/6] insane.bbclass: package_qa_check_license -> do_qa_populate_lic

[Robert Yang <liezhi.yang@windriver.com>]

On 04/26/2016 04:56 PM, Richard Purdie wrote:
> On Mon, 2016-04-25 at 06:51 -0700, Robert Yang wrote:
>> The package_qa_check_license() was in do_qa_configure which had a
>> potential problem, when the recipe sets do_configure[noexec] = "1",
>> then
>> the license checking won't run, which may hidden license issues.
>> Rename
>> it to do_qa_populate_lic() and run in do_populate_lic[postfuncs]
>> which
>> is more reasonable (when no populate license, no license checking).
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/classes/insane.bbclass | 15 ++++++---------
>>   1 file changed, 6 insertions(+), 9 deletions(-)
>
> There is a convention that "do_" as a function prefix means its a task.
> In this case its not a task but a function, so can you use a different
> prefix please?

I had updated the code in V2, but there are others 3 use do_<foo> in
insane.bbclass which are funtions, not tasks:

do_populate_sysroot[postfuncs] += "do_qa_staging "
do_configure[postfuncs] += "do_qa_configure "
do_unpack[postfuncs] += "do_qa_unpack"

What shall we do on them, please ? Keep them or update them?

// Robert

>
> Cheers,
>
> Richard
>