From: Joshua G Lock <joshua.g.lock@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] rootfs-postcommands: don't hard-code .rootfs in manifest filename
Date: Mon, 27 Jun 2016 08:43:31 +0100 [thread overview]
Message-ID: <1467013411.2892.2.camel@linux.intel.com> (raw)
In-Reply-To: <1466590945-10412-1-git-send-email-joshua.g.lock@intel.com>
On Wed, 2016-06-22 at 11:22 +0100, Joshua Lock wrote:
> The .rootfs suffix of a generated image can be overridden by setting
> IMAGE_NAME_SUFFIX, to ensure manifest filenames match the associated
> image make use of this variable in the manifest filename.
This change will break a few external layers so probably isn't worth it
for a minor cosmetic change?
Regards,
Joshua
>
> Signed-off-by: Joshua Lock <joshua.g.lock@intel.com>
> ---
> meta/classes/rootfs-postcommands.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/rootfs-postcommands.bbclass
> b/meta/classes/rootfs-postcommands.bbclass
> index db8b551..c413389 100644
> --- a/meta/classes/rootfs-postcommands.bbclass
> +++ b/meta/classes/rootfs-postcommands.bbclass
> @@ -15,7 +15,7 @@ ROOTFS_POSTPROCESS_COMMAND +=
> "rootfs_update_timestamp ; "
> ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains("IMAGE_FEATURES"
> , "read-only-rootfs", "read_only_rootfs_hook; ", "",d)}'
>
> # Write manifest
> -IMAGE_MANIFEST = "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.manifest"
> +IMAGE_MANIFEST =
> "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.manifest"
> ROOTFS_POSTUNINSTALL_COMMAND =+ "write_image_manifest ; "
> # Set default postinst log file
> POSTINST_LOGFILE ?= "${localstatedir}/log/postinstall.log"
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-06-27 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 10:22 [PATCH 1/2] rootfs-postcommands: don't hard-code .rootfs in manifest filename Joshua Lock
2016-06-22 10:22 ` [PATCH 2/2] openssl: prevent warnings from openssl-c_rehash.sh Joshua Lock
2016-06-27 7:43 ` Joshua G Lock [this message]
2016-06-27 10:12 ` [PATCH 1/2] rootfs-postcommands: don't hard-code .rootfs in manifest filename Patrick Ohly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467013411.2892.2.camel@linux.intel.com \
--to=joshua.g.lock@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox