From: Patrick Ohly <patrick.ohly@intel.com>
To: Joshua G Lock <joshua.g.lock@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] rootfs-postcommands: don't hard-code .rootfs in manifest filename
Date: Mon, 27 Jun 2016 12:12:40 +0200 [thread overview]
Message-ID: <1467022360.25432.22.camel@intel.com> (raw)
In-Reply-To: <1467013411.2892.2.camel@linux.intel.com>
On Mon, 2016-06-27 at 08:43 +0100, Joshua G Lock wrote:
> On Wed, 2016-06-22 at 11:22 +0100, Joshua Lock wrote:
> > The .rootfs suffix of a generated image can be overridden by setting
> > IMAGE_NAME_SUFFIX, to ensure manifest filenames match the associated
> > image make use of this variable in the manifest filename.
>
> This change will break a few external layers so probably isn't worth it
> for a minor cosmetic change?
Agreed, please don't merge yet.
The problem is a bit more complicated: is IMAGE_MANIFEST the manifest
file for the entire image (as the name implies), or just of the main
partition? The two are not necessarily the same, because some image
types combine the main partition with additional content (like a boot
loader and the kernel).
This conceptual issue needs further work.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
prev parent reply other threads:[~2016-06-27 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 10:22 [PATCH 1/2] rootfs-postcommands: don't hard-code .rootfs in manifest filename Joshua Lock
2016-06-22 10:22 ` [PATCH 2/2] openssl: prevent warnings from openssl-c_rehash.sh Joshua Lock
2016-06-27 7:43 ` [PATCH 1/2] rootfs-postcommands: don't hard-code .rootfs in manifest filename Joshua G Lock
2016-06-27 10:12 ` Patrick Ohly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467022360.25432.22.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=joshua.g.lock@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox